1867518 - Deleting history on quit deletes shortcut icons

Status: RESOLVED FIXED

(Firefox for Android :: History, defect, P2)

Description

[Sugar2622]

Steps to reproduce:

I have enabled "delete browsing data on quit" and have unchecked all options except for "browsing history". So when I press quit my browsing history will get deleted but nothing else.

Actual results:

After pressing quit and restarting, all the icons (Favicons? Website logos?) for the my shortcuts on the home page are gone.

Expected results:

Shortcut icons should not get deleted If you go manually to "History -> trash can -> delete everything", then the history gets deleted without losing the shortcut icons. I don't know why deleting the history via "quit" has a different behaviour.

Comment 1

[Kaya [:kaya]]

I could not reproduce this on my device. For now, keeping it as low prio-P3 (399), I will update once hearing from QA.
Forwarding it to QA: can you please verify if this is happening or not?
Update: I could reproduce this and updated the prio/severity accordingly.

Comment 2

[Lorand Janos]

I also managed to reproduce this issue on the latest Nightly (123.0a1), Beta and RC (122).
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as NEW.

Comment 3

[jackyzy823]

I think this is intentional.

If the sites are not PINNED, they will be removed when cleaning history.

the sites are also removed when manually doing "History -> trash can -> delete everything".

Comment 4

[Sugar2622]

(In reply to jackyzy823 from comment #3)

I think this is intentional.

If the sites are not PINNED, they will be removed when cleaning history.

the sites are also removed when manually doing "History -> trash can -> delete everything".

No, this happens to pinned sites as well. And that's exactly what this bug is about.

For some of them (e.g. Reddit, BBC), the thumbnails seem to stay, while for others (e.g. 4chan, DeepL) the thumbnails get removed when you delete history through "quit" (but not when you delete history manually in the settings. It's a bit odd that (1) the two different ways of deleting the history have a different effect on pinned sites' thumbnails, and that (2) some pinned sites' thumbnails stay and others get deleted - perhaps there is a hardcoded list somewhere.

Comment 5

[jackyzy823]

Sorry , i misunderstand the bug.

---

Yes the favicon of shortcuts has gone.

Comment 6

[jackyzy823]

Delete browsing data's code:

https://searchfox.org/mozilla-mobile/source/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/settings/deletebrowsingdata/DeleteBrowsingDataController.kt#47-54

iconsStorage.clear()

It will clear icons' cache.

---

Manually history deletion's code:

https://searchfox.org/mozilla-mobile/rev/fb1581e75f5d8ec45459591638c9b8ce220ae641/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/library/history/state/HistoryStorageMiddleware.kt#64-84

No similar code for clearing icons' cache.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 8

[Lorand Janos]

I've retested it on a current build: Firefox Nightly 136.0a1 from 2024-01-16.
This issue is no longer reproducible. The icons are correctly shown on homescreen.
Tested on a Google Pixel 9 Pro XL (Android 15).
I will close the ticket as Works for me.

Comment 9

[Sugar2622]

Attachment: Homescreen shortcut icon disappears after "delete history on quit"

Still have the same problem on Firefox 134.0.1 and Firefox Nightly 136.0a1, Pixel 8 Android 15.

I have made a screen recording. Added a website (4chan's Tech board) in the shortcuts. Opening it loads the icon for the homescreen. Deleting history via "Quit" makes the icon disappear.

Comment 10

[Sugar2622]

Still have the same problem on Firefox 134.0.1 and Firefox Nightly 136.0a1, Pixel 8 Android 15.

I have made a screen recording. Added a website (4chan's Tech board) in the shortcuts. Opening it loads the icon for the homescreen. Deleting history via "Quit" makes the icon disappear.

Comment 11

[Lorand Janos]

Hi,
I had to pin some shortcuts on homescreen to reproduce the issue, but I did manage to reproduce it.
This time I used a Oneplus 12R (Android 14) and the latest Nightly build (136.0a1 from 2025-01-20).
I'll mark the current build as affected.
Thank you!

Comment 12

[Iorga Gabriel]

Attachment: Bug 1867518 - Deleting history on quit should not delete shortcut icons.

Comment 13

[Iorga Gabriel]

Based on the discussion with Channing on Slack. I removed the icons clear method call.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbc0b54b1fc6
Deleting history on quit should not delete shortcut icons. r=android-reviewers,rsainani

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cbc0b54b1fc6