Closed Bug 1867605 Opened 2 years ago Closed 2 years ago

Record real time and durations when exporting js traces to profiler frontend

Categories

(DevTools :: General, enhancement)

enhancement

Tracking

(firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(3 files, 2 obsolete files)

Bug 1867599 will land a first implementation where each frame is recorded as a 1ms sample, without any other notion of time or duration.
So that each frame is displayed right after each others and are all displayed as lasting for 1ms.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

Insert a fake "label" frame to highlight why JavaScript run and label them with the related DOM event being processed.

Now that the tracer output generates valid data, we can expose this feature by default.

This records a fake "UserTiming" marker, which are optionaly shown in the marker chart.
But given that DOM Mutations don't have a duration, they are barely visible, and can't be hovered.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6227883e96f [devtools] Record actual frame durations in JS tracer profiler data. r=canaltinova,devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/8b4526f5a986 [devtools] Use label frame to highlight DOM Events. r=canaltinova,devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/fc1900aa9cde [devtools] Expose the profiler output for the tracer. r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Blocks: 1903121
Blocks: 1904602

Comment on attachment 9405741 [details]
Bug 1867605 - [devtools] Use new "DOMMutation" marker type (instead of UserTiming)

Revision D212718 was moved to bug 1904602. Setting attachment 9405741 [details] to obsolete.

Attachment #9405741 - Attachment is obsolete: true

Comment on attachment 9405740 [details]
Bug 1867605 - [devtools] Try to show DOM Mutation in stack chart.

Revision D212717 was moved to bug 1904602. Setting attachment 9405740 [details] to obsolete.

Attachment #9405740 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: