1867622 - Finalize icon for WebAuthn conditional UI autofill entries

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, task, P1)

Description

[John Schanck [:jschanck]]

The WebAuthn conditional UI will land in Nightly 122 with a placeholder icon for testing. This bug is to track inclusion of the final icon later in the Nightly 122 cycle.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1867622 - update icon for WebAuthn conditional UI. r=keeler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a38cb4bc0eb
update icon for WebAuthn conditional UI. r=credential-management-reviewers,sgalich

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing passkey.svg related bustages

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3122b127deca
update icon for WebAuthn conditional UI. r=credential-management-reviewers,jneuberger,sgalich

Comment 5

[John Schanck [:jschanck]]

There's going to be one more revision from UX. Marking this as leave-open.

Comment 6

[John Schanck [:jschanck]]

Attachment: Bug 1867622 - finalize icon for WebAuthn conditional UI. r=victoria

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3122b127deca

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08267b4d217d
finalize icon for WebAuthn conditional UI. r=victoria

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/08267b4d217d

Comment 10

[John Schanck [:jschanck]]

Comment on attachment 9368782 [details]
Bug 1867622 - finalize icon for WebAuthn conditional UI. r=victoria

Beta/Release Uplift Approval Request

• User impact if declined: The icon for WebAuthn autofill entries will be slightly smaller than intended.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky. The patch replaces one SVG with another.
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Donal Meehan [:dmeehan]]

:jschanck does this still need to have the leave-open keyword or can it be resolved?

Comment 12

[John Schanck [:jschanck]]

Thanks for the reminder. We're not planning any more changes. I'll mark it resolved.

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9368782 [details]
Bug 1867622 - finalize icon for WebAuthn conditional UI. r=victoria

Approved for 122.0b3

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d232be861a32