1867739 - Support highlighting via context menu

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement, P1)

Comment 1

[Calixte Denizet (:calixte)]

For now, I'll just add an entry in the context menu but no color picker as expected because I don't know how to do that.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Add the possibility to create an highlight from the context menu when some text is selected (bug 1867739) (#17708)

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1867739 - Add an entry in the context menu in order to be able to highlight the selected text in a pdf r=Gijs,#fluent-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f319d88c8aad
Add an entry in the context menu in order to be able to highlight the selected text in a pdf r=Gijs,fluent-reviewers,bolsson

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_pdfjs_editing_contextmenu.js

• backout: https://hg.mozilla.org/integration/autoland/rev/7a9c3375f2d36b696b4c0f0935baa4ba857b134e
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=f319d88c8aad5c8f96ef2dbf7ba94c4bbd9c7425
• failure log: https://treeherder.mozilla.org/logviewer?job_id=450302429&repo=autoland&lineNumber=17346

[task 2024-03-11T11:52:45.146Z] 11:52:45     INFO - TEST-PASS | toolkit/components/pdfjs/test/browser_pdfjs_editing_contextmenu.js | document must have a span containing 'and found references' - true == true - 
[task 2024-03-11T11:52:45.147Z] 11:52:45     INFO - Buffered messages finished
[task 2024-03-11T11:52:45.147Z] 11:52:45     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/browser_pdfjs_editing_contextmenu.js | Test timed out - 
[task 2024-03-11T11:52:45.148Z] 11:52:45     INFO - GECKO(9385) | Completed ShutdownLeaks collections in process 9385

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4e243e08691
Add an entry in the context menu in order to be able to highlight the selected text in a pdf r=Gijs,fluent-reviewers,bolsson

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e4e243e08691