1867847 - Work around missing AppID support in macOS platform security key API

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P1)

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1867847 - part 1: simplify internal service selection in WebAuthnService. r=keeler

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 1867847 - part 2: add hybrid transport identifier. r=keeler

Depends on D195281

Comment 3

[John Schanck [:jschanck]]

Attachment: Bug 1867847 - part 3: use auth-rs for AppID credentials on security keys on macOS. r=keeler

Depends on D195282

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6abaa6e54335
part 1: simplify internal service selection in WebAuthnService. r=keeler
https://hg.mozilla.org/integration/autoland/rev/e27d868dadef
part 2: add hybrid transport identifier. r=keeler
https://hg.mozilla.org/integration/autoland/rev/a5892463f5d7
part 3: use auth-rs for AppID credentials on security keys on macOS. r=keeler

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1868206 for causing bustage on WebAuthnService.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/858db3534bd415ed182d3f8fe9b00277619ed4b9
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=0c3d33cf25c00039576fcca0ab3b14300fa2343d&selectedTaskRun=YyCkacV1RvW4JoMoRek-1w.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=438839098&repo=autoland&lineNumber=35063

[task 2023-12-05T01:36:24.664Z] 01:36:24     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -isysroot /builds/worker/fetches/MacOSX14.0.sdk -mmacosx-version-min=10.15 -stdlib=libc++ --target=x86_64-apple-darwin -o WebAuthnService.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/webauthn -I/builds/worker/workspace/obj-build/dom/webauthn -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/crypto -I/builds/worker/checkouts/gecko/security/manager/ssl -I/builds/worker/checkouts/gecko/third_party/rust -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wduplicate-method-arg -Wduplicate-method-match -Wmissing-method-return-type -Wobjc-signed-char-bool -Wsemicolon-before-method-body -Wsuper-class-method-mismatch -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Werror=unguarded-availability-new -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/WebAuthnService.o.pp   /builds/worker/checkouts/gecko/dom/webauthn/WebAuthnService.cpp
[task 2023-12-05T01:36:24.665Z] 01:36:24    ERROR -  /builds/worker/checkouts/gecko/dom/webauthn/WebAuthnService.cpp:53:9: error: use of undeclared identifier 'MOZ_WEBAUTHN_AUTHENTICATOR_TRANSPORT_ID_INTERNAL'
[task 2023-12-05T01:36:24.665Z] 01:36:24     INFO -     53 |         MOZ_WEBAUTHN_AUTHENTICATOR_TRANSPORT_ID_INTERNAL |
[task 2023-12-05T01:36:24.666Z] 01:36:24     INFO -        |         ^
[task 2023-12-05T01:36:24.670Z] 01:36:24    ERROR -  /builds/worker/checkouts/gecko/dom/webauthn/WebAuthnService.cpp:54:9: error: use of undeclared identifier 'MOZ_WEBAUTHN_AUTHENTICATOR_TRANSPORT_ID_HYBRID'
[task 2023-12-05T01:36:24.670Z] 01:36:24     INFO -     54 |         MOZ_WEBAUTHN_AUTHENTICATOR_TRANSPORT_ID_HYBRID;
[task 2023-12-05T01:36:24.670Z] 01:36:24     INFO -        |         ^
[task 2023-12-05T01:36:24.670Z] 01:36:24     INFO -  2 errors generated.
[task 2023-12-05T01:36:24.670Z] 01:36:24    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:689: WebAuthnService.o] Error 1
[task 2023-12-05T01:36:24.670Z] 01:36:24     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/webauthn'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c064b630f1
part 1: simplify internal service selection in WebAuthnService. r=keeler
https://hg.mozilla.org/integration/autoland/rev/dbc9104c99a8
part 2: add hybrid transport identifier. r=keeler
https://hg.mozilla.org/integration/autoland/rev/ceb036fc7ec8
part 3: use auth-rs for AppID credentials on security keys on macOS. r=keeler

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/58c064b630f1
https://hg.mozilla.org/mozilla-central/rev/dbc9104c99a8
https://hg.mozilla.org/mozilla-central/rev/ceb036fc7ec8