1867893 - has pseudo selector (caching?) issue when child includes focused input

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[krassowski.michal]

Attachment: has.html

Steps to reproduce:

The :has() pseudo-class does not appear to be evaluated correctly when a focused input element is contained in the selected node.

To reproduce:

1. Open the attached has.html file in Firefox 122.0a1 (2023-11-27) (64-bit)
2. (Optional) double-check that layout.css.has-selector.enabled is true
3. Click "Run" button
4. Wait 1 second

Actual results:

Inputs numbered 0-99 are all shown (bad). When you open developer tools to investigate inputs 0-98 get hidden leaving input 99 (good).

Expected results:

Only input 99 is shown after running and waiting 1 second.

Comment 1

[krassowski.michal]

Attachment: repro.gif

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[krassowski.michal]

Attachment: works-in-chromium.gif

This works correctly in Chromium-based browsers.

Comment 4

[krassowski.michal]

It appears that a similar scenario with a simpler selector like:

.parent:has(.child) {
  display: none;
}

works well in both Chromium and Firefox Nightly.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

David, looks like a :has() style invalidation bug, mind taking a look?

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1867893: Do not skip invalidation for `:has` if the stand-in element can be an anchor. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72f1c72ea34c
Do not skip invalidation for `:has` if the stand-in element can be an anchor. r=emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43498 for changes under testing/web-platform/tests

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1853258

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/72f1c72ea34c

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dshin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[David Shin[:dshin]]

Comment on attachment 9366878 [details]
Bug 1867893: Do not skip invalidation for :has if the stand-in element can be an anchor. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect invalidation of some :has() selectors, as shown in Bug 1867893 comment 0.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366878 [details]
Bug 1867893: Do not skip invalidation for :has if the stand-in element can be an anchor. r=emilio

Approved for 121.0b8.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca3cddabbfe3