1868032 - Aspect ratio (DAR) of MP4 Videos are not respected

Status: NEW

(Core :: Audio/Video: Playback, defect, P2)

Description

[Armin Fuerst]

Attachment: FF_aspect_ratio_bug.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I created a video (720x576) and re-coded it as MP4 (not MP4v2) with Avidemux. In the configuration I selected "Force aspect ratio" and set "Aspect Ratio (DAR)" to 16:9.

Actual results:

When I open the video in VLC, Chromium (and other programs), it is properly displayed as a 16:9 video. When I open this video in FF, it is displayed as 4:3.
I attach a ZIP containing a demonstration video to reproduce this bug and screenshot at second 7 from Chromium 119.0.6045.199 and Firefox 115.5.0esr (64-bit).

Expected results:

The video should be displayed with an aspect ratio of 16:9 in firefox.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Karl Tomlinson (:karlt)]

Thank you for the testcase.

Comment 3

[Alastor Wu [:alwu]]

This problem is caused by mp4parse not reading the SAR in the pasp box. Usually SAR will be included in SPS, but in this case, it only exists in the pasp box.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1868032 - part1 : adjust display size using the pixel aspect ratio from the metadata (PASP box).

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1868032 - part2 : add tests.

Depends on D236269

Comment 6

[Alastor Wu [:alwu]]

The part1 will be pulled from mp4parse once the review is finished, this is the PR.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1868032 - part1 : update mp4parse to revision e64650a686e5c5732395cd059e17cfd3b1e5b63b.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40633b3b011f
part1 : update mp4parse to revision e64650a686e5c5732395cd059e17cfd3b1e5b63b. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/80a9c594c271
part2 : adjust display size using the pixel aspect ratio from the metadata (PASP box). r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/49ab1afc6aa7
part3 : add tests. r=media-playback-reviewers,padenot

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out 3 changesets (Bug 1868032) for causing rust vendor linting failures.

Push with failures

Failure log

Backout link

Comment 10

[Cosmin Sabou [:CosminS]]

This also may be coming from latest land: https://treeherder.mozilla.org/logviewer?job_id=493509548&repo=autoland

Comment 11

[Phabricator Automation]

Comment on attachment 9463619 [details]
Bug 1868032 - part1 : update mp4parse to revision e64650a686e5c5732395cd059e17cfd3b1e5b63b.

Revision D236620 was moved to bug 1946245. Setting attachment 9463619 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e5e0a43e77e
part1 : adjust display size using the pixel aspect ratio from the metadata (PASP box). r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5ca219e6d02a
part2 : add tests. r=media-playback-reviewers,padenot

Comment 13

[amarc]

Backed out for causing bc failures @ browser_changePiPSrcInFullscreen.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_changePiPSrcInFullscreen.js | The actual width: 1600. The expected width: 480.24 - Got 1600, expected 480.24 epsilon: +/- 2

Backed out for causing wpt failures @ resize-during-playback.html

• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-video-element/resize-during-playback.html | mp4 video - assert_equals: Expected resize event, but got ended event instead expected "resize" but got "ended"

—————————————————————

Backed out for causing mda failures @ test_hevc_playback.html

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | dom/media/test/test_hevc_playback.html | Test timed out. -

————————————————————
Backed out for causing wpt failures @ mediasource-correct-frames.html

• Failure Log