1868093 - Remove DeadKeyTable class from KeyboardLayout

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Jens Stutte [:jstutte]]

The return value of KeyboardLayout::GetDeadKeyCombinations is always the same value, we can just remove it and its use.

Edit: I am not sure I read this right at the time of filing the bug, but I am glad you are increasing readability here with that change.

Comment 1

[Mathew Hodson]

Attachment: Bug 1868093 - Remove DeadKeyTable class from KeyboardLayout

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mathew.hodson, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca837da136a0
Remove DeadKeyTable class from KeyboardLayout r=win-reviewers,handyman

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12bf09dd0be4
Revert "Bug 1868093 - Remove DeadKeyTable class from KeyboardLayout r=win-reviewers,handyman" for causing mochitests crashes.

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests crashes.

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | application crashed [@ nsTArray_Impl<mozilla::widget::DeadKeyEntry,nsTArrayInfallibleAllocator>::ClearAndRetainStorage] | widget/tests/test_keycodes.xhtml

Comment 7

[Mathew Hodson]

That test doesn't crash for me when I run it locally. I will investigate.

Comment 8

[David Parks [:handyman]]

Comment on attachment 9477135 [details]
Bug 1868093 - Remove DeadKeyTable class from KeyboardLayout

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=2e9fc30c115da72f8bca2f37cd3eef5945b9f4ee

Doesn't need uplift.

Comment 9

[Mathew Hodson]

(In reply to David Parks [:handyman] from comment #8)

Doesn't need uplift.

The reason Phabricator started associating this with beta is because of bug 1963406. I fixed the repo on Phab so it is still fine to land.

Comment 10

[Mathew Hodson]

:handyman, can you land this for me?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/97decaf05589
https://hg.mozilla.org/integration/autoland/rev/5dc4fd53145d
Remove DeadKeyTable class from KeyboardLayout r=win-reviewers,handyman

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5dc4fd53145d