Introduce a new linter and verification task to verify that firefox-addons fetch task includes all xpi files being used in condprof customization json files
Categories
(WebExtensions :: General, task, P2)
Tracking
(firefox123 fixed)
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
Details
(Whiteboard: [addons-jira])
Attachments
(1 file, 1 obsolete file)
As a followup to Bug 1859549 we agreed to look into adding a new linter and verification task that explicitly verify that all xpi files that are being used in condprof customization json file are being included in the firefox-addons fetch task.
The goal of the linter is to prevent us to miss to notice that a new xpi file url has been added to a condprof customization file without also adding it to the firerox-addons archive to avoid downloading it multiple times when running in a CI job (but to still allow us to run throwaway try push runs with a given xpi file to be used only once).
This followup bugzilla issue has been spun off from the discussion in phabricator comments here:
- https://phabricator.services.mozilla.com/D191199#6453396
- https://phabricator.services.mozilla.com/D191199#6468821
As a side note, a new linter added also in support of the perftests (to validate the perftests docs are being regenerated as expected) was introduced in Bug 1587080, and it may be likely useful as a source of inspiration while working on this bug.
|
Assignee | |
Updated•5 months ago
|
|
||
Updated•5 months ago
|
|
|
Assignee | |
Comment 1•5 months ago
|
||
Depends on D194637
|
||
Updated•5 months ago
|
|
|
Assignee | |
Comment 2•5 months ago
|
||
Push to try including both the changes included in the patch attached in comment 1 + a temporary patch adding an additional xpi file to the customization file which is not in the firefox-addons archive to trigger the expected linting error to be logged by the verification task:
|
|
Assignee | |
Comment 3•5 months ago
|
||
Sample phab revision to trigger the linting error expected to be reported by the new linter on phabricator.
NOT intended to be landed.
Depends on D195434
|
|
||
Updated•3 months ago
|
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/cd38cf3f7807 Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
|
||
Comment 5•3 months ago
•
|
||
Backed out for causing mozlint-condprof-addons failures
- Backout link
- Push with failures
- Failure Log
- Failure line: Exception: Despite being a CI lint job, no files were linted. Is the task missing explicit paths?
|
|
Assignee | |
Comment 6•3 months ago
•
|
||
(In reply to Cristian Tuns from comment #5)
Backed out for causing mozlint-condprof-addons failures
- Backout link
- Push with failures
- Failure Log
- Failure line: Exception: Despite being a CI lint job, no files were linted. Is the task missing explicit paths?
The failure was triggered by a missing path in the mach lint command as it was defined the confprof-addons-verifier mozlint run command, I have updated the patch on phabricator (adding "." as the explicit path command to lint, consistently with the other linters defined in mozlint.yml) and will push the patch to autoland again after my push to try confirmed that change fixed the failure as it should.
|
|
Assignee | |
Comment 7•3 months ago
|
||
The condprof-addons-verify mozlint task passed as expected with the update applied in my last push to try:
I'll push this to autoland again.
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/e7c123513a8b Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
|
||
Comment 9•3 months ago
|
||
| bugherder | ||
Description
•