Closed Bug 1868154 Opened 9 months ago Closed 9 months ago

RFPHelper depends on a string from browser.properties

Categories

(Core :: Privacy: Anti-Tracking, defect)

defect

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: eemeli, Assigned: eemeli)

Details

Attachments

(1 file)

The toolkit's RFPHelper.sys.mjs is the only user of the privacy.spoof_english defined in browser.properties. This is one of the last (ab)users of browser.properties in toolkit, and should be migrated to Fluent.

Assignee: nobody → earo
Status: NEW → ASSIGNED

I've added a patch that should fix this, but it looks like this part of RFPHelper code is untested.

How could I manually trigger the prompt that's changed here to verify that it still renders as expected?

Flags: needinfo?(tihuang)

You will need to use a non-English locale build and flip the pref privacy.resistFingerprinting to true.

Flags: needinfo?(tihuang)
Attachment #9366884 - Attachment description: WIP: Bug 1868154 - Convert RFPHelper strings to Fluent → Bug 1868154 - Convert RFPHelper to Fluent. r?timhuang!
Blocks: 1866297
No longer blocks: 1866297
Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53bf1328c0b8
Convert RFPHelper to Fluent. r=timhuang,fluent-reviewers,bolsson
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: