Closed Bug 1868180 Opened 7 months ago Closed 7 months ago

Default browser.shopping.experience2023.ads.userEnabled to true

Categories

(Firefox :: Shopping, enhancement, P1)

Firefox 121
All
Unspecified
enhancement

Tracking

()

VERIFIED FIXED
122 Branch
Tracking Status
firefox121 --- verified
firefox122 --- verified

People

(Reporter: asafko, Assigned: niklas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce

  1. Enroll into the treatment A branch of the https://experimenter.services.mozilla.com/nimbus/review-checker-ads/summary

Expected result

  1. Ads are displayed on eligible products in RC.
  2. Ads display toggle in RC settings is enabled

Actual result

  1. Ads are not displayed on eligible products in RC.
  2. Ads display toggle in RC settings is disabled (the toggle is greyed out).

As the state of the display toggle is governed with browser.shopping.experience2023.ads.userEnabled, we would like to either default its value to true (or make it available to Nimbus and persistent) to remedy this.

Flags: needinfo?(ctataru)
Summary: Make browser.shopping.experience2023.ads.userEnabled available to Nimbus → Default browser.shopping.experience2023.ads.userEnabled to true
Flags: needinfo?(ctataru)
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f742e02849d8
Default browser.shopping.experience2023.ads.userEnabled to true. r=shopping-reviewers,kpatenio
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

Comment on attachment 9366904 [details]
Bug 1868180 - Default browser.shopping.experience2023.ads.userEnabled to true. r=#shopping-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: We need to flip this pref for the shopping ads experiment to work properly in 121.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very low risk. We're just flipping a pref that changes the behavior of a feature that is disabled for everyone, in order to make a future experiment work as expected.
  • String changes made/needed: None
  • Is Android affected?: Unknown
Attachment #9366904 - Flags: approval-mozilla-beta?

Comment on attachment 9366904 [details]
Bug 1868180 - Default browser.shopping.experience2023.ads.userEnabled to true. r=#shopping-reviewers

Approved for 121.0b9.

Attachment #9366904 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed in our latest Beta 121.0b9 as well as our latest Nightly build, the browser.shopping.experience2023.ads.userEnabled pref is enabled by default which means users that are enrolled in this experiment and has browser.shopping.experience2023.ads.enabled and browser.shopping.experience2023.enabled set to true they will automatically see ads in the Review checker sidebar.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: