1868187 - Expose native function call arguments to onNativeCall hooks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

For now Debugger.onNativeCall hook only exposes reason (call, get or set) and callee (a Debugger.Object reference of the function being called.
But it would be helpful for the JS Tracer (bug 1803616) to also expose the arguments being passed to that native function call. May be only do that via an additional Debugger flag as that won't be useful for eager evaluation usecase.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1868187 - Expose native call arguments via Debugger.inspectNativeCallArguments and Debugger.onNativeCall.

Also expose the object onto which the native method is called, if any.
This will allow to describe the class related to the method call.

Expose this additional data only on-demand so that the usage of onNativeCall
related to console eager evaluation, which do not need this data,
can avoid this extra computation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3db7aa730ed
Expose native call arguments via Debugger.inspectNativeCallArguments and Debugger.onNativeCall. r=arai

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e3db7aa730ed