1868194 - Convert TelemetryFeed.jsm into an ESM

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

TelemetryFeed uses the injection system in its unit test which is incompatible with ESMs. This means that prior to converting the module, we must convert TelemetryFeed.test.js into an xpcshell test. This bug covers doing both things.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1868194 - TelemetryFeed.uninit should unregister all preference observers. r?thecount!

Prior to this patch, we would add preference observers during TelemetryFeed.init,
but never remove them on uninit. In the common case, a TelemetryFeed is only ever
created once, so this is mostly fine - but in rare cases (for example, a user chooses
to disable and re-enable TelemetryFeed multiple times via prefs) or in automated
testing (where we create, init and destroy many instances of TelemetryFeed), failing
to remove preference observers means that we keep the feed alive even after its
uninitted, and also continue to have it react to preference changes.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1868194 - Convert some PingCentre ping schema tests from joi to JSON schema. r?thecount!

Depends on D197729

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1868194 - Convert TelemetryFeed.test.js to an xpcshell test. r?thecount!

Depends on D197730

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1868194 - Convert TelemetryFeed.jsm to an ESM. r?thecount!

Depends on D197731

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c3b418aaed
TelemetryFeed.uninit should unregister all preference observers. r=thecount
https://hg.mozilla.org/integration/autoland/rev/d2435c55c2d5
Convert some PingCentre ping schema tests from joi to JSON schema. r=thecount
https://hg.mozilla.org/integration/autoland/rev/81d8db80d8ac
Convert TelemetryFeed.test.js to an xpcshell test. r=thecount
https://hg.mozilla.org/integration/autoland/rev/cb76a44a3e41
Convert TelemetryFeed.jsm to an ESM. r=thecount

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/13c3b418aaed
https://hg.mozilla.org/mozilla-central/rev/d2435c55c2d5
https://hg.mozilla.org/mozilla-central/rev/81d8db80d8ac
https://hg.mozilla.org/mozilla-central/rev/cb76a44a3e41