Closed Bug 1868247 Opened 2 years ago Closed 2 years ago

Update PDF.js to new version a3637e653fd1b8570b998e93c0e123c398411c79 from 2023-12-04 15:58:41

Categories

(Firefox :: PDF Viewer, enhancement)

Product:
Firefox
Component:
PDF Viewer
Type:
enhancement

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox122 --- affected

People

(Reporter: update-bot, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [3pl-filed][task_id: UymSYjs1SISGWoJb66x67A])

This update covers 11 commits. Here are the overall diff statistics, and then the commit information.

toolkit/components/pdfjs/content/build/pdf.mjs | 23 +++++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 6 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 44 ++++++-------
toolkit/components/pdfjs/content/web/viewer.css | 32 ++++++++-
toolkit/components/pdfjs/content/web/viewer.mjs | 47 +++++++-------
toolkit/components/pdfjs/moz.yaml | 4 +-
7 files changed, 94 insertions(+), 66 deletions(-)

43eea0b38e87d3ed75a88a4027c6ea6d3954b8b3 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/43eea0b38e87d3ed75a88a4027c6ea6d3954b8b3
Authored: 2023-12-04 13:27:30 +0100
Committed: 2023-12-04 13:27:39 +0100

[Editor] Make sure that all layers are disabled when an editing session is done

Fixes issue #17368.

Files Modified:

  • src/display/editor/annotation_editor_layer.js
  • test/integration/ink_editor_spec.mjs

ac5667166e5a74e07918872115259ac0f418280a by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/ac5667166e5a74e07918872115259ac0f418280a
Authored: 2023-12-03 16:31:45 +0100
Committed: 2023-12-03 20:42:50 +0100

Modernize the verifyManifestFiles test helper function

The test helper code largely predates the introduction of modern
JavaScript features and should be refactored to improve readability.
In particular callbacks and recursive function calls make the code
harder to understand and maintain.

This commit:

  • replaces the callback argument with returning a promise;
  • replaces the recursive function calls with a simple loop;
  • uses const/let instead of var;
  • uses template strings for shorter string formatting code;
  • improves the error messages to have more details.

Files Modified:

  • test/downloadutils.mjs
  • test/test.mjs

c9a923066ba85cacd58900a85712e720cd161790 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/c9a923066ba85cacd58900a85712e720cd161790
Authored: 2023-12-03 16:22:47 +0100
Committed: 2023-12-03 20:42:45 +0100

Modernize the calculateMD5 test helper function

The test helper code largely predates the introduction of modern
JavaScript features and should be refactored to improve readability.
In particular callbacks and recursive function calls make the code
harder to understand and maintain.

This commit:

  • replaces the callback argument with returning a promise;
  • uses const instead of var;
  • uses arrow functions for shorter code;
  • uses template strings for shorter string formatting code;
  • improves the error messages to have more details.

Files Modified:

  • test/downloadutils.mjs

8bb807011603840a9cd9bac8977f08531059de45 by manunio

https://github.com/mozilla/pdf.js/commit/8bb807011603840a9cd9bac8977f08531059de45
Authored: 2023-11-26 04:54:21 +0530
Committed: 2023-12-03 18:52:48 +0530

fuzz: initial integration - Adds initial fuzz_target for image decoders. - Adds jazzer.js as dev-dependency. - Adds a .eslintrc rule to ignore import/no-unresolved error.

Files Added:

  • test/fuzz/.eslintrc
  • test/fuzz/README.md
  • test/fuzz/jbig2_image.fuzz.js
  • test/fuzz/jpeg_image.fuzz.js
  • test/fuzz/jpx_image.fuzz.js

Files Modified:

  • package-lock.json
  • package.json

83d0b6cb55744365d6a811e320bbdd7a3f3f012c by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/83d0b6cb55744365d6a811e320bbdd7a3f3f012c
Authored: 2023-12-01 17:10:19 +0100
Committed: 2023-12-01 17:10:19 +0100

[Editor] Disable mouse events when leaving the highlight mode

Files Modified:

  • src/display/editor/highlight.js
  • web/annotation_editor_layer_builder.css

4c92ec900894172cd9e16ffd7b388e544f3e7018 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/4c92ec900894172cd9e16ffd7b388e544f3e7018
Authored: 2023-12-01 12:01:05 +0100
Committed: 2023-12-01 12:16:56 +0100

[Firefox] Restore opening of PDF attachments (issue 17353)

This unfortunately broke in PR 17060, since I had completely forgotten about https://bugzilla.mozilla.org/show_bug.cgi?id=1632644#c5 when writing that patch.
The easiest solution, while slightly unfortunate, seems to be to add a couple of non-standard hash parameters specifically for the PDF attachment use-case in the Firefox PDF Viewer. (Note that we cannot use "nameddest" here, since we also need to support the stringified destination-Array case.)

Files Modified:

  • web/firefoxcom.js
  • web/pdf_link_service.js

fe3bc575deef2b6caa31db067bf5b834a76ca29d by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/fe3bc575deef2b6caa31db067bf5b834a76ca29d
Authored: 2023-11-30 20:47:15 +0100
Committed: 2023-11-30 20:47:15 +0100

Disable the "should compress and save text" unit-test in additional Node.js versions (PR 17202 follow-up)

It seems this unit-test started failing in Node.js version 20.10 as well. We should probably try and understand why, but for now just disable it to get passing CI tests.

Files Modified:

  • test/unit/annotation_spec.js

412502370d2efee794d934524ade39a1ddfe79c8 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/412502370d2efee794d934524ade39a1ddfe79c8
Authored: 2023-11-30 20:29:40 +0100
Committed: 2023-11-30 20:29:40 +0100

Remove the "transitionend" event listener from the default viewer (issue 17347)

Given that this event listener is only used to trigger rendering after the sidebar has been opened/closed, we can utilize the existing one in the PDFSidebar class for this purpose instead. That one is registered on the sidebar DOM-element, and is needed to remove a CSS-class indicating that the sidebar is moving.

Files Modified:

  • web/app.js
  • web/pdf_sidebar.js

9052327e07e95d95a1085bb9aba596180d63f33e by Henrik Skupin

https://github.com/mozilla/pdf.js/commit/9052327e07e95d95a1085bb9aba596180d63f33e
Authored: 2023-11-30 09:40:57 +0100
Committed: 2023-11-30 09:40:57 +0100

Use "count" and not "clickCount" when calling page.mouse.click()

Files Modified:

  • test/integration/freetext_editor_spec.mjs

91eda77f63b23b1fe6a3f789e2b4e281e7a7839f by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/91eda77f63b23b1fe6a3f789e2b4e281e7a7839f
Authored: 2023-11-29 16:50:00 +0100
Committed: 2023-11-29 19:53:03 +0100

[Editor] Fix the colors in HCM when hovering a button in the editor toolbar

It fixes few errors in the CSS for HCM.
It now complies to the specs from UI/UX.
Only the foreground must change in HCM and not the background, similarly to what
we had for the alt-text button before moving it.

Files Modified:

  • web/annotation_editor_layer_builder.css

05ca005eebed9b11515240728315ad4b390d87e5 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/05ca005eebed9b11515240728315ad4b390d87e5
Authored: 2023-11-29 11:09:18 +0100
Committed: 2023-11-29 11:09:22 +0100

[Editor] Fix subtype for telemetry data (follow-up of #17329)

Fix a test failure in m-c.

Files Modified:

  • src/display/editor/alt_text.js

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=0701bd2c189d85cd9ff050d6d3e8336d8f36e625

Updatebot encountered an error while trying to submit to phabricator.
Updatebot will be unable to do anything more for this library version.

Flags: needinfo?(cdenizet)

Superseded by https://bugzilla.mozilla.org/show_bug.cgi?id=1868594.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(cdenizet)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.