1868332 - Packaging and appearance highlights are not being parsed

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P1)

Description

[Rahul Sainani [:rsainani]]

Steps to reproduce

1. Turn on ReviewChecker by self enrolling in the experiment.
2. Navigate to this product page

Expected behavior

Highlights should show packaging category as well (confirm by opening the same pdp on desktop)

Actual behavior

Highlights does not show packaging category

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[Cathy Lu [:calu]]

Attachment: Bug 1868332 - Update shopping product highlight key for packaging and appearance

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/802aadd7e045
Update shopping product highlight key for packaging and appearance r=geckoview-reviewers,rsainani,owlish

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/802aadd7e045

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Cathy Lu [:calu]]

Beta/Release Uplift Approval Request

User impact if declined: Review Quality Checker will have appearance/packaging highlights missing from the analysis.
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Not yet
Needs manual test from QE?: Yes
If yes, steps to reproduce: On products with available appearance/packaging highlights (ex: www.amazon.com/Flagship-Capacity-Capsule-Display-Storage/dp/B07BQLL6YY?th=1), bottom sheet highlight should include packaging.
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The fix takes the correct json key "appearance/packaging" instead of "packaging" which returned null all the time.
String changes made/needed: N/A
Is Android affected?: Yes

Comment 6

[Cathy Lu [:calu]]

Comment on attachment 9367295 [details]
Bug 1868332 - Update shopping product highlight key for packaging and appearance

Beta/Release Uplift Approval Request

• User impact if declined: Review Quality Checker will have appearance/packaging highlights missing from the analysis.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On products with available appearance/packaging highlights (ex: www.amazon.com/Flagship-Capacity-Capsule-Display-Storage/dp/B07BQLL6YY?th=1), bottom sheet highlight should include packaging.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix takes the correct json key "appearance/packaging" instead of "packaging" which returned null all the time.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367295 [details]
Bug 1868332 - Update shopping product highlight key for packaging and appearance

Approved for 121.0b9.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d35bba51ef44

Comment 9

[miralobontiu]

Attachment: Screenshot_1.jpg

Verified as fixed on the latest Fenix Nightly 122.0a1 from 12/8 with Samsung Galaxy Note 8 (Android 9), and Google Pixel 6 (Android 14).

Comment 10

[miralobontiu]

Attachment: Screenshot_1.jpg

Verified as fixed on the Beta 121.0b9 build with Google Pixel 8 (Android 14).