1868348 - Distinguish redirect loop caused by endless HTTPS-HTTP loop

Status: NEW

(Core :: Networking: HTTP, task, P2)

Description

[Kershaw Chang [:kershaw]]

Currently, Firefox fails to differentiate between redirect loops caused by a cycle between HTTPS and HTTP and other types of redirect loops. Currently, we use the same error code NS_ERROR_REDIRECT_LOOP and show the same error page, leading to potential misinterpretation and difficulty in troubleshooting HTTPS and HTTP loop caused by HTTPS-only or HTTPS-first mode.

The first step might be using a different error code for HTTPS-HTTP loop.

Comment 1

[Manuel Bucher [:manuel]]

Currently we show the HTTPS-only error page for errors where a https-only upgrade was involved (including the redirect loop). In some cases this doesn't trigger (when starting at the https page, because then no real https-only upgrade was triggered, only the loop detection). Https-first doesn't show a redirect loop at all, it just loads the http page.

What could be added is to

• show the https-only error page when https-only mode is enabled and the user startet at the https page (i.e. enters https://example.com/ and it redirects to http://example.com
• don't show the https-only error page when the page has hsts enabled, because hsts has higher priority than https-only mode.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

I guess what we need here is:

• A test for this situation
• A new error code in ErrorList.py
• Return the new error code in nsHttpChannel when upgrading the channel to secure (and a channel in the redirect chain also did a HTTPS upgrade using secure)?