1868364 - WPT failure in css/css-contain/content-visibility/content-visibility-vs-scrollIntoView-001.html

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Jihye Hong]

test result: https://treeherder.mozilla.org/logviewer?job_id=434372993&repo=autoland&lineNumber=1785

Comment 2

[Jihye Hong]

Attachment: Bug 1868364 - Fix tiny pixels differ around 'P' on Win

This patch fixes test failures because of tiny pixels differ around 'P' by specifying ahem font

Comment 3

[Frédéric Wang]

Current annotation is windows only: https://searchfox.org/mozilla-central/rev/1a63fee6c2a8ea6846f6f16b85edeb6d19fc9f23/testing/web-platform/meta/css/css-contain/content-visibility/content-visibility-vs-scrollIntoView-001.html.ini

I guess using Ahem as in Jihye patch should fix the issue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ac5fd6eb5d
Fix tiny pixels differ around 'P' on Win r=cathiechen

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43599 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/19ac5fd6eb5d

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This change caused 2 tests to regress on both Chrome and Safari:
https://github.com/web-platform-tests/wpt/pull/43599/checks?check_run_id=19515603050
https://github.com/web-platform-tests/wpt/pull/43599/checks?check_run_id=19515486970
https://bugs.chromium.org/p/chromium/issues/detail?id=1510865

Comment 9

[Jihye Hong]

Attachment: Bug 1868364 - Revert content-visibility-with-popover-top-layer-005.html and content-visibility-with-top-layer-005.html which cause regression

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bbbf7953c52
Revert content-visibility-with-popover-top-layer-005.html and content-visibility-with-top-layer-005.html which cause regression r=cathiechen

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43663 for changes under testing/web-platform/tests

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out changeset 2bbbf7953c52 (Bug 1868364) for causing failures in /content-visibility-with-top-layer-005.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2bbbf7953c52f44f29ad2d44f6d85cd02b5ed38b&selectedTaskRun=SllexW_YTralsBZ9hpb4eg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=440116353&repo=autoland&lineNumber=9619
TV: https://treeherder.mozilla.org/logviewer?job_id=440117183&repo=autoland&lineNumber=2200

Backout https://hg.mozilla.org/integration/autoland/rev/90f4cada04fb84cb381124010675a381305c6261

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Joey Arhar]

The tests in comment 8 are still failing in safari and chrome:
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-005.html
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-with-top-layer-005.html
Is this expected?

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5a6d5b7dbc5
Revert content-visibility-with-popover-top-layer-005.html and content-visibility-with-top-layer-005.html which cause regression r=cathiechen

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b5a6d5b7dbc5

Comment 17

[Frédéric Wang (:fredw)]

(In reply to David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla) from comment #8)

This change caused 2 tests to regress on both Chrome and Safari:
https://github.com/web-platform-tests/wpt/pull/43599/checks?check_run_id=19515603050
https://github.com/web-platform-tests/wpt/pull/43599/checks?check_run_id=19515486970
https://bugs.chromium.org/p/chromium/issues/detail?id=1510865

(In reply to Joey Arhar from comment #14)

The tests in comment 8 are still failing in safari and chrome:
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-005.html
https://wpt.fyi/results/css/css-contain/content-visibility/content-visibility-with-top-layer-005.html
Is this expected?

I think they should be passing again, but it looks like the revert from https://github.com/web-platform-tests/wpt/pull/43663 has not been merged yet.

@James: can you please take a look?

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 20

[Frédéric Wang (:fredw)]

Thanks!