1868368 - Disabling Rich Entities will remove all potential rich suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Attachment: fen_720.jpg

Found in

• 122.0a1 2023-12-05

Affected versions

• Nightly 122.0a1 2023-12-05

Tested platforms

• Affected platforms: Win 10 64-bit, OSX 10.14
• Unaffected platforms: -

Preconditions

• browser.urlbar.richSuggestions.featureGate set to true
• browser.search.param.search_rich_suggestions set to "fen"

Steps to reproduce

1. Type a popular keyword inside the Address Bar (eg. David) - Search suggestions are shown alongside Rich entities.
2. Go to about:config and switch browser.urlbar.richSuggestions.featureGate to false.
3. Repeat step 1 using the same keyword

Expected result
Same search suggestions as in step 1 are returned, this time without an icon.

Actual result
The previously displayed rich suggestions are not shown anymore as simple suggestions, leaving a reduced suggestions list.

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:phorea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1868368 - Show suggestions without icons when richsuggestions are disabled. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf5ee34a91ea
Show suggestions without icons when richsuggestions are disabled. r=adw

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bf5ee34a91ea

Comment 5

[Petruta Horea [:phorea]]

Verified as fixed on Firefox 122 beta 2 across platforms. After switching the pref to false, normal suggestions are displayed.