1868428 - Add ShadowRoot::clonable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

A corresponding attribute for ShadowRootInit::clonable.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1868428 - Add ShadowRoot clonable attribute r=avandolder

Depends on D193677

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ade0be35500e
Add ShadowRoot clonable attribute r=avandolder,webidl,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43602 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ade0be35500e

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Vadim Makeev]

Hey! I’m currently documenting this addition in BCD, MDN, and release notes. As far as I understand, it’s Nightly only and won’t be shipped in Firefox 122 by default. Did I get it right?

Also, I tried to test it in the current Firefox Nightly 123, but I got false in the console:

const host = document.createElement('div');
const shadowRoot = host.attachShadow({mode: 'open', cloneable: true});
shadowRoot.cloneable;

In Safari TP 186 I get true.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Vadim Makeev from comment #6)

Hey! I’m currently documenting this addition in BCD, MDN, and release notes. As far as I understand, it’s Nightly only and won’t be shipped in Firefox 122 by default. Did I get it right?

Yes, it's currently Nightly only. Bug 1870052 will enable it on all channels later.

Also, I tried to test it in the current Firefox Nightly 123, but I got false in the console:

const host = document.createElement('div');
const shadowRoot = host.attachShadow({mode: 'open', cloneable: true});
shadowRoot.cloneable;

In Safari TP 186 I get true.

Hi, it's because it's not cloneable but clonable (see there's no e before able). Looks like Safari has some typo? I filed https://bugs.webkit.org/show_bug.cgi?id=267634.

Comment 8

[Vadim Makeev]

Oh my, English is hard! I’m glad we did it right as clonable per spec. I’ll make sure there are no cloneable in MDN :)