1868464 - `moz-phab uplift` doesn't warn nor error if the expected head doesn't exist

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Mark Banner (:standard8)]

STR

1. Have a freshly checked out repository (possibly mozilla-central) where the beta/release heads don't appear.
2. Try something like moz-phab uplift --train beta

Expected Results

Either attempt to pull and checkout beta, or fail.

Actual Results

No rebase happens but the patch is submitted regardless.

Comment 1

[Connor Sheehan [:sheehan]]

If the target head isn't in the repo, we still want to submit the uplift request. However I see how that is confusing, especially if you're used to the rebasing behaviour. I'll add a warning output that target head couldn't be found and the commit will be submitted without rebasing.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: uplift: add a warning when an uplift will be submitted without rebase (Bug 1868464) r?zeid

Add a warning message to the output of moz-phab uplift when a
target head could not be found for uplift. In this case we will
still submit the patch as an uplift request without rebasing onto
the latest changes.