1868562 - Perma dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface WakeLock to all webpages as a property on 'window'? Do not mak when Gecko 122 merges to Beta on 2023-12-18

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Norisz Fay [:noriszfay]]

Central-as-beta simulation

How to run these simulations

Failure log:

[task 2023-12-06T13:00:45.838Z] 13:00:45     INFO - TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | AudioBuffer is exposed as an own property on 'window' but tests false for "in" in the global scope 
[task 2023-12-06T13:00:45.839Z] 13:00:45     INFO - TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | AudioBuffer is exposed as an own property on 'window' but has no property descriptor in the global scope 
[task 2023-12-06T13:00:45.839Z] 13:00:45     INFO - Buffered messages finished
[task 2023-12-06T13:00:45.840Z] 13:00:45     INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface WakeLock to all webpages as a property on 'window'? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) 
[task 2023-12-06T13:00:45.840Z] 13:00:45     INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:426:16
[task 2023-12-06T13:00:45.840Z] 13:00:45     INFO - runTest@https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:2032:7
[task 2023-12-06T13:00:45.841Z] 13:00:45     INFO - @https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:2083:8
[task 2023-12-06T13:00:45.841Z] 13:00:45     INFO - TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | WakeLock is exposed as an own property on 'window' but tests false for "in" in the global scope 
[task 2023-12-06T13:00:45.841Z] 13:00:45     INFO - TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | WakeLock is exposed as an own property on 'window' but has no property descriptor in the global scope 

It seems there are also multiple wpt failures on /screen-wake-lock/* that are all regressed by the same bug.
Assertion failure log (Bug 1855699), AddressSanitizer failure, Process-crash

Comment 1

[Vincent Hilla [:vhilla]]

I think, Pref="dom.screenwakelock.enabled" needs to be added to WakeLock.webidl and WakeLockSentinel.webidl. I only added it in Navigator.webidl and forgot the other two. That should fix this bug.

The failures in wpt stem from observing a pref change. I guess in WakeLockJS::Observe, instead of asserting there to be an extrant document, we could check whether there is one and otherwise do nothing. The asan failure also comes from accessing the document, but I'm wondering why no assertion was triggered.

I will try to get a patch ready later.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 4

[Donal Meehan [:dmeehan]]

:vhilla The Fx122 nightly soft code freeze starts on 2023-12-14, with Fx122 going to beta on 2023-12-18.
If you are still on track to have a patch for this by the end of this week?

Comment 5

[Edgar Chen [:edgar]]

I will take a look.

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=869d9e6ca31d8f43c39e7904115d084cf25ac55f

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1868562 - WakeLock and WakeLockSentinel should have a pref guard; r?smaug,#dom-core

which should be exposed on Nightly only.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b665081b155
WakeLock and WakeLockSentinel should have a pref guard; r=smaug

Comment 9

[Noemi Erli[:noemi_erli]]

Edgar, I've imported the patch in today's beta simulation, but it doesn't seem to work, as we still have these:

• https://treeherder.mozilla.org/logviewer?job_id=440109336&repo=try&lineNumber=13517
• https://treeherder.mozilla.org/logviewer?job_id=440109912&repo=try&lineNumber=13533
  and this seems a new one: https://treeherder.mozilla.org/logviewer?job_id=440119255&repo=try&lineNumber=10059
  Could you please take a look?

Comment 10

[Edgar Chen [:edgar]]

This patch only fix the test_interfaces_secureContext.html error, I am going to handle the crash in bug 1869118.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1b665081b155

Comment 12

[Norisz Fay [:noriszfay]]

Verified fixed as there are no more related failures in today's beta-sim

Comment 13

[Intermittent Failures Robot]

5 failures in 4224 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 5

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1
• linux1804-64-qr: 2
  • debug: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1868562&startday=2023-12-11&endday=2023-12-17&tree=all