1868591 - PollPromise is logging the error message even if the polling succeeds before the timeout

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Julian Descottes [:jdescottes]]

The PollPromise helper accepts an errorMessage option, but this will be logged both when the polling times out and when it succeeds.

We could set a flag before we call resolve(...) in the timeout case (searchfox) and then check it before logging the warning.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Maybe we could make it async/await as well while touching it? It would help a lot.

Comment 2

[Alexandra Borovova [:Sasha]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #1)

Maybe we could make it async/await as well while touching it? It would help a lot.

I would move it to a separate bug, since I think it's not very straightforward.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1868591 - Fix PollPromise timeout warning.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5094efab355
Fix PollPromise timeout warning. r=webdriver-reviewers,jdescottes

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f5094efab355