1868604 - Size of the review checker sidebar should be remembered after closing sidebar and restarting browser

Status: VERIFIED FIXED

(Firefox :: Shopping, defect)

Description

[Peter Magyari (Desktop QA)]

Found in

• Nightly 122.0a1 (2023-12-06)

Affected versions

• Nightly 122.0a1

Affected platforms

• All

Preconditions:
Set the browser.shopping.experience2023.enabled - true
Set the browser.shopping.experience2023.optedIn - 1

Steps to reproduce

1. Reach this amazon product page. (or any other)
2. Resize the Review Checker sidebar to a random size.
3. Close the Review Checker sidebar.
4. Restart browser.
5. Go to a Amazon product page and re-open the Review Checker sidebar.

Expected result

• The size of the Review Checker sidebar should not reset to default.

Actual result

• The size of the Review Checker sidebar is re-set to default.

Notes

• This does not occur if you only resize and close/reopen the sidebar. (without restarting)

Regression range

• I'll be back with a regression range ASAP.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:pmagyari, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Peter Magyari (Desktop QA)]

Mozregression pointed to: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=620e49ab6438e8c933133e9b4eb7a11188514a70&tochange=68378d2409bc693ef00f3f157ecaea7067df7edc

Not sure which change could've introduced this though.

Comment 3

[Donal Meehan [:dmeehan]]

Pinging triage owner :jhirsch to see if this can be triaged.
The Fx122 nightly soft code freeze starts on 2023-12-14, with Fx122 going to beta on 2023-12-18.
This was set as an S3 regression by QA, though the regressor wasn't identified.
Could you take a look to get a needinfo on this to the correct person?

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The shopping sidebar width is stored in the browser.shopping.experience2023.sidebarWidth pref.

If the sidebar is closed after setting the width, the stored value is cleared.

If the sidebar is resized, then the tab is closed (but the sidebar is left open), the sidebar width value seems to persist across restarts for me in a local build from latest mozilla-central.

Could you try again to identify if there's a bug here, and if so, what are the steps to reproduce? Thank you

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:niklas, did I miss anything here, or does the feature look the same to you as it did when it landed?

Comment 6

[Niklas Baumgardner [:niklas]]

Ahh, I see the bug. The bug occurs when the sidebar is closed because this.scrollWidth is undefined when we get a resize when the sidebar is closed.

I'll submit a patch to fix this.

Comment 7

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1868604 - Only record reasonable widths for shopping sidebar. r=#shopping-reviewers

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #2, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:niklas, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 9

[Donal Meehan [:dmeehan]]

:niklas we are in nightly soft freeze for Fx122, we go to beta on 2023-12-18.
If you could land this before then?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585faf485ebe
Only record reasonable widths for shopping sidebar. r=shopping-reviewers,Gijs,desktop-theme-reviewers,dao

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/585faf485ebe

Comment 12

[Peter Magyari (Desktop QA)]

Verified fixed on Firefox Nightly 122.0a1 (20231216095116) on MacOS 11.6 and Windows 10.