1868707 - Clear-icon in the search field in Firefox View is not accessible

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect)

Description

[Anna Yeddi [:ayeddi]]

The control lacks role and cannot be focused with a keyboard.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1868707 - Make Clear-icon control in the search field in Firefox View accessible. r=#fxview-reviewers!

Adding a role and including the implicit button in the logical focus order of the page.

Comment 2

[Sarah Clements [:sclements]]

Thanks Anna! I'll close out bug 1868587 as a dupe :)

Comment 4

[Anna Yeddi [:ayeddi]]

(In reply to Sarah Clements [:sclements] from comment #2)

Thanks Anna! I'll close out bug 1868587 as a dupe :)

Oh, I thought I searched for the bug well :) Thank you, Sarah!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e31e3db84e9
Make Clear-icon control in the search field in Firefox View accessible. r=fxview-reviewers,sclements

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5e31e3db84e9

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The focus can now be set on the clear button as expected, but the button can't be interacted with (enter, space, esc) nothing happens. This is reproducible on macOS 13, Win 11 and Ubuntu 22.04. Any idea Anna?

Comment 8

[Anna Yeddi [:ayeddi]]

(In reply to Catalin Sasca, Desktop QA [:csasca] from comment #7)

The focus can now be set on the clear button as expected, but the button can't be interacted with (enter, space, esc) nothing happens. This is reproducible on macOS 13, Win 11 and Ubuntu 22.04. Any idea Anna?

Oh, thank you for catching this, Catalin! I’ll send another patch to this bug.

Comment 9

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1868707 - Make Clear-icon control in the search field in Firefox View keyboard actionable. r=#fxview-reviewers!

Ensuring the Enter and Space keys are working to activate the Clear button in Firefox View and adding a few tests to prevent regressions.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/668d3b3fb830
Make Clear-icon control in the search field in Firefox View keyboard actionable. r=fxview-reviewers,kcochrane

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/668d3b3fb830

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the clear buttons are now functional (both with space and enter) in every section of Firefox View in Firefox 122.0a1 (2023-12-13) on Windows 11, macOS 13 and Ubuntu 22.04.

Comment 13

[Anna Yeddi [:ayeddi]]

(In reply to Catalin Sasca, Desktop QA [:csasca] from comment #12)

Verified that the clear buttons are now functional (both with space and enter) in every section of Firefox View in Firefox 122.0a1 (2023-12-13) on Windows 11, macOS 13 and Ubuntu 22.04.

Thank you a lot for the verification, Catalin!