1868721 - RtpLogging produces inconsistent log format

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The formatting of RtpLogger messages is largely up to the logging caller. The importance of this is not obvious, and has proven fragile. Adding a marker which indicates the portion of the message of interest would go a long way to making RtpLogger log messages easy to reformat for text2pcap ingestion.

The previous (broken) method of getting to portion of interest was:

cat log | egrep '(RTP_PACKET|RTCP_PACKET)' | cut -d '|' -f 2 | cut -d ' ' -f 5-

With this patch it is the following:

cat log  | rg 'RtpLogger.*RTC?P_PACKET|>>\s(?P<packet>.+$)' --only-matching  --replace '$packet'

The advantages are that none of key tokens in the new format come from the log site and the regex is more resilient to log message changes which would throw off cut operations.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1868721 - make RtpLogger output format more robust;r?#webrtc-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1848749

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b512531e17
make RtpLogger output format more robust;r=webrtc-reviewers,mjf

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b9b512531e17