1868738 - On macOS with multiple monitors, the about window always opens on the main monitor

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P5)

Description

[Fernando García Gómez, stripTM]

A MacBook connected to several external monitors.
Firefox instantiated on one of the external monitors, when the "about" menu is selected, the popup with the information is always displayed on the integrated display. It would be desirable that it opens on the same screen on which Firefox is running.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

That looks like a defect report to me more than an enhancement request.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Josh Aas]

Attachment: Bug 1868738 - Open the About Firefox window on whatever monitor has the most recent Firefox window. r?#firefox-desktop-core-reviewers

Comment 5

[Josh Aas]

The issue here is that on macOS the About Firefox dialog is default associated with the hidden window, which is always on the main monitor. As a result, the About Firefox dialog always appears on the main monitor. The fix is to open it based on the most recent window.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c2485448f7f9
https://hg.mozilla.org/integration/autoland/rev/89c99fce0f20
Open the About Firefox window on whatever monitor has the most recent Firefox window. r=firefox-desktop-core-reviewers ,mossop

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/89c99fce0f20

Comment 8

[Josh Aas]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is annoyance for anyone accessing the About menu with multiple monitors. Multi-monitor bugs have been a relatively common complaint for Firefox users, I think it's good to make people aware of improvements.
[Affects Firefox for Android]: No
[Suggested wording]: In multiple monitor situations, the About Firefox window will now open on the display with the most recently used Firefox window rather than always opening on the primary display.
[Links (documentation, blog post, etc)]:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 relnotes.