1868788 - [Inactive CSS] Show table-related CSS properties as inactive when they're not on a table-related element

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Julien Wajsberg [:julienw]]

I noticed border-spacing and border-collapse, but there may be others.

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1868788 - [devtools] Handle table-related issues in inactive CSS. r=#devtools-reviewers.

Comment 2

[Sebastian Zartner [:sebo]]

border-spacing and border-collapse seem to be the only ones left that had to be tested. The other table-related properties like table-layout and empty-cells are already tested.

Sebastian

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sebo, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I think everything was good. Sebo, is there anything preventing us from landing this?

Comment 5

[Sebastian Zartner [:sebo]]

No, I just forgot to land this. ☺️ I've pushed this to Lando now.

Sebastian

Comment 6

[Sebastian Zartner [:sebo]]

Needed to do a rebase. Trying to land again.

Sebastian

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd8670544009
[devtools] Handle table-related issues in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fd8670544009