1868828 - Add support for vendor specific WebDriver BiDi modules

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For Mozilla specific APIs in our WebDriver BiDi implementation we need a way to handle vendor specific commands and events. In our case commands could look like moz:debugger.start.

To properly separate such modules from those that are officially part in the WebDriver Bidi specification, we should put those into their own folder. We should potentially call it moz.

As such our code in the WebDriverBiDiConnection module should not only split by ., but also : to check for potential prefixes, and handle them if appropriate. Routing should basically be similar to the other modules.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: WIP: Bug 1868828 - Implement vendor specific modules in WebDriver BiDi r?whimboo!,jdescottes!

Comment 2

[Julien Wajsberg [:julienw]]

Existing API in CDP: https://chromedevtools.github.io/devtools-protocol/tot/Profiler/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Julien Wajsberg [:julienw] from comment #2)

Existing API in CDP: https://chromedevtools.github.io/devtools-protocol/tot/Profiler/

Thanks! I assume that was meant for bug 1868805.

Comment 4

[Julian Descottes [:jdescottes]]

Nazim, do you mind if I take over this one?
I can provide a patch with tests for the framework part.

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yes, please feel free to take over this one.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1868828 - [remote] Add support for vendor specific WebDriver BiDi modules

This adds tests and framework support for vendored modules in MessageHandler

We also add the moz: prefix to the WebDriver BiDi ModuleRegistry

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1868828 - [remote] Add example of a moz:Profiler BiDi module

Depends on D241233

(not intended for review, just an example)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98b5b9085b7
[remote] Add support for vendor specific WebDriver BiDi modules r=webdriver-reviewers,whimboo

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b98b5b9085b7