1868866 - Re-introduce enforcing alphabetically sorted test manifests for toml files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[:Gijs (he/him)]

Code in https://searchfox.org/mozilla-central/rev/1a63fee6c2a8ea6846f6f16b85edeb6d19fc9f23/tools/lint/test-manifest-alpha/__init__.py is currently specific to .ini files. We should extend it to cover .toml test manifests. Mike says this should be easier than it was to do .ini!

Comment 1

[Mark Banner (:standard8)]

I think this might be a duplicate of bug 1847269?

Comment 2

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #1)

I think this might be a duplicate of bug 1847269?

I guess this bug describes a desired outcome and that bug describes a method of getting there - so likely to be dupes but not necessarily - leave it up to :jmaher to make a decision here.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

keeping this as the master bug

Comment 5

[Tom Marble]

Attachment: Bug 1868866 - adds ManifestParser TOML linter r=jmaher

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be67d91cf16
adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ee57b62e0eaebcf40f6f74acadae2cbc124d0b1

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/xre/test/marionette/test_exitcode.py TestFissionAutostart.test_exit_code | AssertionError: 0 != 5

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

this is an Marionette OSX only failure related to sorting the manifests in the master list of manifests.

logic would dictate that if this isn't seen on other platforms, then this must be related to anything that is skip-if || run-if os == 'mac'. It might be wise to include culprits that skip-if || run-if any other platform as those could be missing or running on linux/win and causing other environment/profile/browser interference.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e38088e4e8c
adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2e38088e4e8c