1868906 - Allow FFmpegVideoEncoder continues encoding after Drain()

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P1)

Description

[C.M.Chang[:chunmin]]

Bug 1860899 is going to implement a FFmpegVideoEncode. The Drain() is implemented by sending NULL to the avcodec_send_frame(), which can leave the encoder in a permanent EOF state and the encoder is unable to continue encoding in EOF state.

To continue encoding after Drain(), a new AVCodecContext/encoder creation is required.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1868906 - Add Encode() after Drain() tests

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1868906 - Move Init work to a function

Depends on D195906

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1868906 - Move Shutdown work to a function

Depends on D195907

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1868906 - Recreate AVCodecContext after draining

Depends on D195908

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81acf461e6a8
Add Encode() after Drain() tests r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/117f0de1506c
Move Init work to a function r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/84f0fd345b1f
Move Shutdown work to a function r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e3a43409dd5a
Recreate AVCodecContext after draining r=media-playback-reviewers,padenot

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/81acf461e6a8
https://hg.mozilla.org/mozilla-central/rev/117f0de1506c
https://hg.mozilla.org/mozilla-central/rev/84f0fd345b1f
https://hg.mozilla.org/mozilla-central/rev/e3a43409dd5a