1868917 - the snap has a packaging bug ... where can I see source and submit patch?

Status: RESOLVED DUPLICATE of bug 1826330

(Firefox Build System :: Third Party Packaging, defect)

Description

[Tim Richardson]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

See https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2045820
for screenshots

In the Linux snap package,
firefox snap .desktop is missing StartupWMClass
Icons are broken in KDE and Gnome

this is repost from https://forum.snapcraft.io/t/snap-icons-is-the-firefox-desktop-file-missing-startupwmclass/37400

I have the mozilla stable version installed using the mozilla binary method, and snap for the beta channel. The snap icon is broken, both in the menu entry and in the panel. That is, there is no icon in menu, and the generic cog icon in the panel.

This is on 22.04 But I have the same problem in 23.10 and in a VM 22.04. That is, I can reproduce this every time.

I did snap remove firefox

to uninstall, but this file

/home/tim/.local/share/applications/firefox_firefox.desktop

remains.

So I remove it manually, and reinstall.

The desktop file for this is now:

/var/lib/snapd/desktop/applications/firefox_firefox.desktop

It is called Firefox Web Browser in the gnome launcher, and it has an icon. But after launching, it still uses the generic cog icon in the panel. The context menu from this icon has no actions, except to Quit. If I create a second window, both are associated with this icon, which is good.

In the Gnome launcher, if you search for an app and if that app is running, the Gnome launcher indicates it with a dot. However, while this works for the mozilla binary, the icon of Firefox Web Browser (installed with snap) does not show a dot, even though I have two windows from it open.

image: see attachment firefox_bug_0.png

image: see attachment firefox_bug_1.png

Fix?

From chatgpt help, I see this:

image: see attachment firefox_bug_3.png

Add this line to the snap .destkop file, near the top, fixed it:

StartupWMClass=firefox-beta

Therefore my suggestion is that the .desktop file have a channel-dependent StartupWMClass value set.

Actual results:

see See https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2045820

Expected results:

See See https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2045820

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Tim Richardson]

this is for snap packaging, and concerns the desktop file and it kde plasma desktop as well, according to a "me too" report here.
Is the really a Core::Widget:Gtk bug?

Comment 3

[Jens Stutte [:jstutte]]

Moving it closer to someone who hopefully knows which component this should be.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gerard-majax, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[:gerard-majax]

The desktop file is copied during the Snap build process: https://github.com/canonical/firefox-snap/blob/97e60fb29518e2ae60c5a3433b066e41d0a17b66/snapcraft.yaml#L427 and we have no StartupWMClass https://searchfox.org/mozilla-central/rev/f961e5f2a22f4d41733545190892296e64c06858/taskcluster/docker/firefox-flatpak/firefox.desktop but this is also the case for Flatpak ...

Looking at bug 1826330 i'm wondering how much all of that is just a dupe ?