1868962 - Update Temporal implementation to draft Nov 6, 2023

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 1: Avoid calendar operations when adding days-only duration to ZDT. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/ec1df1f178578eecad0b027b8c96a20d30b2c590

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 2: Avoid extra allocations when calling GetInstantFor. r=#spidermonkey-reviewers!

Adds PlainDateTimeWithCalendar to avoid PlainDateTimeObject allocations where
possible.

Depends on D195864

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 3: Fast-path AddDaysToZonedDateTime in AddZonedDateTime. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/5194420e7d70fa1ae67c489f3b3b84955d1b2989

Depends on D195865

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 4: Avoid calendar operations when adding days-only duration to PlainDate. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/1ff91a9730ace0af31177afab5c57bc343a5ab2f

Depends on D195866

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 5: Fast-path dateAdd() when adding only days. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/db1e0b33cd09284bf81fde141dec661e74844def

Depends on D195867

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 6: Fast-path differences between identical objects. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/27c8876007c043982201f1939a2da3e8b696237a

Depends on D195868

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 7: Prefer PlainObject for resolved options objects. r=#spidermonkey-reviewers!

Prefer PlainObject instead of JSObject as a hint that the options object
aren't arbitrary objects.

Depends on D195869

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 8: Fast-path dateUntil() when difference largest unit is days. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/4bd36244f0de8420a08faa10d4614f7fe435d3a6

Depends on D195870

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 9: Simplify NanosecondsToDays. r=#spidermonkey-reviewers!

Part 8 ensures that the initial value of days doesn't exceed ±200'000'000. This
allows to change days from double to int64_t, because overflowing an int64
value which starts at ±200'000'000 and can only incremented by one can't happen in
a reasonable amount of time.

Depends on D195871

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 10: Look up getOffsetNanosecondsFor only once when resolving ambiguous datetime. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/72d61c2296665aac023561ce00c6b11d6319a941

Depends on D195872

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 11: Precalculate PlainDateTime from ZonedDateTime in more places. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/6eec81db8645823bd361310daa7b575fb702ac9f

Depends on D195873

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 12: Fix absolute value bug in duration rounding no-op conditions. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/26369ba0cf5be4b9dc8c6cecb5de16acba09e2e6

Depends on D195874

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 13: Avoid ZonedDateTimeObject allocations where possible. r=#spidermonkey-reviewers!

Similar to part 2, we can avoid allocating ZonedDateTimeObject in a couple of places.

Depends on D195875

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 14: Avoid ZonedDateTimeObject allocations in ToTemporalZonedDateTime. r=#spidermonkey-reviewers!

Use ZonedDateTime also for ToTemporalZonedDateTime to avoid unnecessary allocations.

Depends on D195876

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 15: Remove no longer used CreateTemporalTimeZoneUTC. r=#spidermonkey-reviewers!

Depends on D195877

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 16: Use comparison operator to compare plain-date-time values. r=#spidermonkey-reviewers!

Prefer the overloaded == operator to make the code a bit more readable.

Depends on D195878

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 17: Add PlainDateWithCalendar. r=#spidermonkey-reviewers!

Similar to parts 2 and 13, add a class to replace PlainDateObject when no
allocations are necessary.

Depends on D195879

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 18: Fixes for editorial issues. r=#spidermonkey-reviewers!

Implement the changes from:
https://github.com/tc39/proposal-temporal/pull/2708

Depends on D195880

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 19: Set largestUnit property on resolvedOptions after early return. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/019a632a4f70c3ea55c412ae36404ba75f7464e4

Depends on D195881

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 20: DRY out ISO 8601 PlainMonthDay reference year defaulting. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/771da57e986e03ea44b6b64fe81466c2fbcb66b5

Depends on D195882

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 21: Look up time zone methods only once. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/fce7ec8a1fc603861f81d4a557f345af304a9d90

Depends on D195883

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 22: Look up calendar methods only once. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/57ec4591ec780db0249181e8ac2beff55fe8b2c7

Depends on D195884

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 23: Avoid extra Zoned→Plain conversion in AddDuration. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/dce8cf42d30ca59ad6a41105d0a01096bfa659ef

Depends on D195885

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1868962 - Part 24: Enable now passing tests. r=#spidermonkey-reviewers!

Depends on D195886

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6df27d326e9
Part 1: Avoid calendar operations when adding days-only duration to ZDT. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/54b2c01ed865
Part 2: Avoid extra allocations when calling GetInstantFor. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/2b1659f24e43
Part 3: Fast-path AddDaysToZonedDateTime in AddZonedDateTime. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3c19db04360b
Part 4: Avoid calendar operations when adding days-only duration to PlainDate. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/8bc5d28a55ec
Part 5: Fast-path dateAdd() when adding only days. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/09119edb585e
Part 6: Fast-path differences between identical objects. r=sfink
https://hg.mozilla.org/integration/autoland/rev/cac76e7f171b
Part 7: Prefer PlainObject for resolved options objects. r=sfink
https://hg.mozilla.org/integration/autoland/rev/2a0942c538f1
Part 8: Fast-path dateUntil() when difference largest unit is days. r=sfink
https://hg.mozilla.org/integration/autoland/rev/d1384db54f32
Part 9: Simplify NanosecondsToDays. r=sfink
https://hg.mozilla.org/integration/autoland/rev/87c17ad2de55
Part 10: Look up getOffsetNanosecondsFor only once when resolving ambiguous datetime. r=sfink
https://hg.mozilla.org/integration/autoland/rev/67d542cd14c2
Part 11: Precalculate PlainDateTime from ZonedDateTime in more places. r=dminor
https://hg.mozilla.org/integration/autoland/rev/1261d998e9b0
Part 12: Fix absolute value bug in duration rounding no-op conditions. r=dminor
https://hg.mozilla.org/integration/autoland/rev/5cb45a4b559e
Part 13: Avoid ZonedDateTimeObject allocations where possible. r=dminor
https://hg.mozilla.org/integration/autoland/rev/b7f5df35f348
Part 14: Avoid ZonedDateTimeObject allocations in ToTemporalZonedDateTime. r=dminor
https://hg.mozilla.org/integration/autoland/rev/9545b271651d
Part 15: Remove no longer used CreateTemporalTimeZoneUTC. r=dminor
https://hg.mozilla.org/integration/autoland/rev/917cc39b3b39
Part 16: Use comparison operator to compare plain-date-time values. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/ff642fa3e86a
Part 17: Add PlainDateWithCalendar. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/09aff6fb6f43
Part 18: Fixes for editorial issues. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/184063472826
Part 19: Set largestUnit property on resolvedOptions after early return. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/d8371c1bd48c
Part 20: DRY out ISO 8601 PlainMonthDay reference year defaulting. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/eed6a07c17b8
Part 21: Look up time zone methods only once. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6dce71a010ec
Part 22: Look up calendar methods only once. r=sfink
https://hg.mozilla.org/integration/autoland/rev/2ee6514b17f8
Part 23: Avoid extra Zoned→Plain conversion in AddDuration. r=dminor
https://hg.mozilla.org/integration/autoland/rev/b5f1bc911ef4
Part 24: Enable now passing tests. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/4e756f339ef8
apply code formatting via Lando

Comment 26

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a6df27d326e9
https://hg.mozilla.org/mozilla-central/rev/54b2c01ed865
https://hg.mozilla.org/mozilla-central/rev/2b1659f24e43
https://hg.mozilla.org/mozilla-central/rev/3c19db04360b
https://hg.mozilla.org/mozilla-central/rev/8bc5d28a55ec
https://hg.mozilla.org/mozilla-central/rev/09119edb585e
https://hg.mozilla.org/mozilla-central/rev/cac76e7f171b
https://hg.mozilla.org/mozilla-central/rev/2a0942c538f1
https://hg.mozilla.org/mozilla-central/rev/d1384db54f32
https://hg.mozilla.org/mozilla-central/rev/87c17ad2de55
https://hg.mozilla.org/mozilla-central/rev/67d542cd14c2
https://hg.mozilla.org/mozilla-central/rev/1261d998e9b0
https://hg.mozilla.org/mozilla-central/rev/5cb45a4b559e
https://hg.mozilla.org/mozilla-central/rev/b7f5df35f348
https://hg.mozilla.org/mozilla-central/rev/9545b271651d
https://hg.mozilla.org/mozilla-central/rev/917cc39b3b39
https://hg.mozilla.org/mozilla-central/rev/ff642fa3e86a
https://hg.mozilla.org/mozilla-central/rev/09aff6fb6f43
https://hg.mozilla.org/mozilla-central/rev/184063472826
https://hg.mozilla.org/mozilla-central/rev/d8371c1bd48c
https://hg.mozilla.org/mozilla-central/rev/eed6a07c17b8
https://hg.mozilla.org/mozilla-central/rev/6dce71a010ec
https://hg.mozilla.org/mozilla-central/rev/2ee6514b17f8
https://hg.mozilla.org/mozilla-central/rev/b5f1bc911ef4
https://hg.mozilla.org/mozilla-central/rev/4e756f339ef8