1869087 - Crash in [@ mozilla::dom::cache::Context::OnQuotaInit]

Status: RESOLVED FIXED

(Core :: Storage: Cache API, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/b5248e4c-c819-49cf-b37d-9d7a60231206

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(mCipherKeyManager)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::dom::cache::Context::OnQuotaInit  dom/cache/Context.cpp:1031
1  xul.dll  mozilla::dom::cache::Context::QuotaInitRunnable::Run  dom/cache/Context.cpp:463
2  xul.dll  nsThread::ProcessNextEvent  xpcom/threads/nsThread.cpp:1192
2  xul.dll  NS_ProcessNextEvent  xpcom/threads/nsThreadUtils.cpp:480
3  xul.dll  mozilla::ipc::MessagePumpForNonMainThreads::Run  ipc/glue/MessagePump.cpp:330
4  xul.dll  MessageLoop::RunInternal  ipc/chromium/src/base/message_loop.cc:370
4  xul.dll  MessageLoop::RunHandler  ipc/chromium/src/base/message_loop.cc:363
5  xul.dll  MessageLoop::Run  ipc/chromium/src/base/message_loop.cc:345
5  xul.dll  nsThread::ThreadFunc  xpcom/threads/nsThread.cpp:370
6  nss3.dll  _PR_NativeRunThread  nsprpub/pr/src/threads/combined/pruthr.c:399

Comment 1

[Harveer Singh]

Seems like we should only be asserting for mCipherKeyManager being non-null when aRV is not an error here: https://hg.mozilla.org/mozilla-central/file/30004166d9f2cc3399da68e8762c35b1b886c0dc/dom/cache/Context.cpp#l1031

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is a new parent process crash. S2

Comment 3

[Harveer Singh]

Attachment: Bug 1869087: Properly handle QuotaInitRunnable failure in Context::OnQuotaInit.r=#dom-storage-reviewers

QuotaInitRunnable is invoked by Context to set up cache directory. This is not always successful as it could be
interrupted by shutdown or other filesystem issues. In case of error, it's possible that mCipherKeyManager is
not initialized by the time it ran into error. QuotaInitRunnable will transition to 'complete' state in both success
and failure scenario and it would call into Context::onQuotaInit. So, we shouldn't assert for mCipherKeyManager in there
as it was not initialized and Context gets dropped there (in case of an error) so it's not needed in that case as well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f47f48be162a
Properly handle QuotaInitRunnable failure in Context::OnQuotaInit.r=dom-storage-reviewers,janv

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset f47f48be162a (Bug 1869087) for causing crashes in StorageControllerTest CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=DOY7igShRDCsJ3D_dqdELg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f47f48be162af5091d26d7332b14da41d5058e4e

Log: https://treeherder.mozilla.org/logviewer?job_id=439901962&repo=autoland&lineNumber=17325

Backout: https://hg.mozilla.org/integration/autoland/rev/6f6ca39797ce4479c06ce891d7dae607b819e5a6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04b0ed50a187
Properly handle QuotaInitRunnable failure in Context::OnQuotaInit.r=dom-storage-reviewers,janv

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing multiple Quota related failures

Backout link

Push with failures

Failure log 1 // Failure log 2 // Failure log 3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9293f88ac9f
Properly handle QuotaInitRunnable failure in Context::OnQuotaInit.r=dom-storage-reviewers,janv

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a9293f88ac9f

Comment 10

[Harveer Singh]

Resolving this as fixed since the linked bug got fixed and landed.