1869195 - Crash in [@ mozilla::PresShell::GetRootScrollFrame]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Wayne Mery (:wsmwk)]

Crash report: https://crash-stats.mozilla.org/report/index/f08e906a-3062-4b0c-b4e6-1f45f0231113 user reports "scrolling down a printing view for one of the e-mails with photos attached to them iwhen it suddenly completely crashed."

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  mozilla::UniquePtr<nsCSSFrameConstructor, mozilla::DefaultDelete<nsCSSFrameConstructor> >::get const  mfbt/UniquePtr.h:286
0  xul.dll  mozilla::UniquePtr<nsCSSFrameConstructor, mozilla::DefaultDelete<nsCSSFrameConstructor> >::operator-> const  mfbt/UniquePtr.h:281
0  xul.dll  mozilla::PresShell::GetRootScrollFrame const  layout/base/PresShell.cpp:2483
0  xul.dll  mozilla::PresShell::GetRootScrollFrameAsScrollable const  layout/base/PresShell.cpp:2492
1  xul.dll  nsDocumentViewer::GetCurrentSheetFrameAndNumber const  layout/base/nsDocumentViewer.cpp:3103
2  xul.dll  nsDocumentViewer::GetPrintPreviewCurrentPageNumber  layout/base/nsDocumentViewer.cpp:3165
3  xul.dll  XPTC__InvokebyIndex  
4  xul.dll  CallMethodHelper::Invoke  js/xpconnect/src/XPCWrappedNative.cpp:1627
4  xul.dll  CallMethodHelper::Call  js/xpconnect/src/XPCWrappedNative.cpp:1180
4  xul.dll  XPCWrappedNative::CallMethod  js/xpconnect/src/XPCWrappedNative.cpp:1126

Comment 1

[Wayne Mery (:wsmwk)]

bp-67c28aad-f6de-46b5-8816-859c60231009 "I had a print dialouge open but had not printed yet. I went into the vies settings and expermented with activating and deactivating menues and email options. The program suddenly closed"

bp-364011e9-4bf3-4672-a86a-44f260230917 "I hit Cancel on the Print dialog and Thuderbird crashed."

Comment 2

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/releases/mozilla-esr115/file/tip/layout/base/PresShell.cpp#l2483 which is https://searchfox.org/mozilla-central/rev/c003be8b9727672e7d30972983b375f4c200233f/layout/base/PresShell.cpp#2428 on trunk. mFrameConstructor must be null

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1869195 - Fix crash in [@ mozilla::PresShell::GetRootScrollFrame]. r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b6b2768fa6
Fix crash in [@ mozilla::PresShell::GetRootScrollFrame]. r=emilio

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f7b6b2768fa6

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9367888 [details]
Bug 1869195 - Fix crash in [@ mozilla::PresShell::GetRootScrollFrame]. r=emilio

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: crash fix
• User impact if declined: may crash
• Fix Landed on Version: 122
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just added null checking

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9367888 [details]
Bug 1869195 - Fix crash in [@ mozilla::PresShell::GetRootScrollFrame]. r=emilio

Approved for 115.7esr.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/6bab46d3a1e7