1869332 - Teach ffvpx to encode AV1 using libaom

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Move libaom to libgkcodecs. r?glandium

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Ask generate_source_mozbuild.py to build the encoder side of libaom. r?glandium

Depends on D196058

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Regenerate libaom/sources.mozbuild and config files. r?glandium

Depends on D196059

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Remove .orig files that crept in. r?chunmin

Drive-by, nothing to do with this bug.

Depends on D196060

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Write a placeholder implementation for getting the buildconfig. r?chunmin

This is expected to be present in ffmpeg, but is only for displaying things on
the command-line, we don't need a "real" implementation.

Depends on D196061

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Add an av1 encoder based on libaom to ffvpx. r?chunmin

Depends on D196062

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f557e130d997
Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/af22bc552759
Ask generate_source_mozbuild.py to build the encoder side of libaom. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1c4b5311ac03
Regenerate libaom/sources.mozbuild and config files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/74e2acabc439
Remove .orig files that crept in. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/661e520c2991
Write a placeholder implementation for getting the buildconfig. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4f8c19f9dfcf
Add an av1 encoder based on libaom to ffvpx. r=chunmin

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: ld.lld: error: undefined hidden symbol: aom_codec_error_detail

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1869332 - Temporarily disable libaom fuzzing. r?pehrsons

We're going to reevaluate which AV1 library we're using anyways, and we're not
using libaom anymore for decode, we're using libdav1d.

This is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1869986

Depends on D196063

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5acc2f4f12c2
Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/00ceb6e47715
Ask generate_source_mozbuild.py to build the encoder side of libaom. r=glandium
https://hg.mozilla.org/integration/autoland/rev/c83313202040
Regenerate libaom/sources.mozbuild and config files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/c401449274b4
Remove .orig files that crept in. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/483d3f275da7
Write a placeholder implementation for getting the buildconfig. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d51eba30a225
Add an av1 encoder based on libaom to ffvpx. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/1c0fd259312d
Temporarily disable libaom fuzzing on debug. r=pehrsons

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 7 changesets (Bug 1869332) for causing libavcodec related bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=KBOoxWpTQUy8TojDf_zLuQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1c0fd259312d4631a0d1a7e0ea0560cff577beba

Log: https://treeherder.mozilla.org/logviewer?job_id=440093469&repo=autoland&lineNumber=103189

Backout: https://hg.mozilla.org/integration/autoland/rev/e3da8f11c87b21bd640baea64b927325ae6331df

Comment 12

[Alex Finder]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f557e130d997
Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/af22bc552759
Ask generate_source_mozbuild.py to build the encoder side of libaom.
r=glandium
https://hg.mozilla.org/integration/autoland/rev/1c4b5311ac03
Regenerate libaom/sources.mozbuild and config files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/74e2acabc439
Remove .orig files that crept in. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/661e520c2991
Write a placeholder implementation for getting the buildconfig. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4f8c19f9dfcf
Add an av1 encoder based on libaom to ffvpx. r=chunmin

== Change summary for alert #40656 (as of Wed, 13 Dec 2023 14:00:29 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	installer size	osx-cross		89,529,780.25 -> 90,742,760.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40656

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfab47873174
Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/2909ac6aeb41
Ask generate_source_mozbuild.py to build the encoder side of libaom. r=glandium
https://hg.mozilla.org/integration/autoland/rev/295a1e1f01d5
Regenerate libaom/sources.mozbuild and config files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/5e775f2c2b9c
Remove .orig files that crept in. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/03ac3598f84f
Write a placeholder implementation for getting the buildconfig. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/886e59d6495f
Add an av1 encoder based on libaom to ffvpx. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e1a7852ec85a
Temporarily disable libaom fuzzing. r=pehrsons

Comment 14

[Narcis Beleuzu [:NarcisB]]

Backed out for Android bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/ebd8fb3263179f1be7461922a31519856b0e07cd
Log link: https://treeherder.mozilla.org/logviewer?job_id=440710356&repo=autoland&lineNumber=70905

Comment 15

[C.M.Chang[:chunmin]]

Attachment: Bug 1869332 - Move libaom files to Non MOZ_FFVPX_AUDIOONLY builds

The av_base64_decode and av_base64_encode in libaomenc.c are only
exposed in NON MOZ_FFVPX_AUDIOONLY builds [1], so libaom files should
be built in non audio-only builds as well.

[1] https://searchfox.org/mozilla-central/rev/008ce958417fd724e02748740d669aafd49debb3/media/ffvpx/libavutil/avutil.symbols#6-9

Comment 16

[C.M.Chang[:chunmin]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #14)

Backed out for Android bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/ebd8fb3263179f1be7461922a31519856b0e07cd
Log link: https://treeherder.mozilla.org/logviewer?job_id=440710356&repo=autoland&lineNumber=70905

D196925 should fix the android build error: https://treeherder.mozilla.org/jobs?repo=try&revision=af458a9e78bd871c60e1ac1ac951cb2ba43a7ac0

Tested with media tests as well: https://treeherder.mozilla.org/jobs?repo=try&revision=013c01d7857aeafd793d27032f0041db471ed474&selectedTaskRun=G6-MIbGdStCnp2gmmCGrxA.0

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54785b4a8579
Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/99928aff2e46
Ask generate_source_mozbuild.py to build the encoder side of libaom. r=glandium
https://hg.mozilla.org/integration/autoland/rev/57f11a1e2268
Regenerate libaom/sources.mozbuild and config files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1ff8d858ccdc
Remove .orig files that crept in. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/078ac62a9145
Write a placeholder implementation for getting the buildconfig. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/fe159bf30548
Add an av1 encoder based on libaom to ffvpx. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/40ac5494688f
Temporarily disable libaom fuzzing. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/44452d446cf6
Move libaom files to Non MOZ_FFVPX_AUDIOONLY builds r=media-playback-reviewers,jolin

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/54785b4a8579
https://hg.mozilla.org/mozilla-central/rev/99928aff2e46
https://hg.mozilla.org/mozilla-central/rev/57f11a1e2268
https://hg.mozilla.org/mozilla-central/rev/1ff8d858ccdc
https://hg.mozilla.org/mozilla-central/rev/078ac62a9145
https://hg.mozilla.org/mozilla-central/rev/fe159bf30548
https://hg.mozilla.org/mozilla-central/rev/40ac5494688f
https://hg.mozilla.org/mozilla-central/rev/44452d446cf6