Closed Bug 1869367 Opened 2 years ago Closed 4 days ago

Add a migrator for the Arc browser

Categories

(Firefox :: Migration, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
relnote-firefox --- 162+
firefox162 --- fixed

People

(Reporter: mconley, Assigned: niklas, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fide-fi])

Attachments

(1 external file)

For people wanting to switch from Arc to Firefox, we should try to make it easier for them to migrate their data over. This bug is for doing that.

Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED

Hey :cheff, I'm working on an Arc migrator for Firefox and saw you recently added one to Zen. I'd like your feedback and I want to make sure whatever lands is useful to Zen too.

My patch is up at https://phabricator.services.mozilla.com/D337289.

Some pieces that might be reusable for you in Zen:

  • _resolveSubfolders in ChromeMigrationUtils: finds Arc's Windows Store package folder by name prefix, since the folder name includes a hash.
  • _getPermissionFolder / _getDataPathFromPermissionFolder: on macOS, the user grants access to the Arc folder which is the parent of User Data, because Arc keeps its sidebar data there.

My migrator differs from Zen's in what it creates: each Space becomes a bookmark folder and Favorites become toolbar bookmarks, but the parsing could be shared. Your ZenMigrationUtilsClass.parseArcSidebar already returns a plain { favorites, spaces } object. Would you be open to moving it into ArcMigrationUtils in Firefox? Firefox would turn the plan into bookmarks, and Zen could keep its own applyArcSidebar on top of it.

Thanks!

Flags: needinfo?(cheff)
Whiteboard: [fide-fi]

Thanks for the heads-up!

I'll update Zen to use your patch and our Arc migrator subclasses yours.

Yes to moving parseArcSidebar into ArcMigrationUtils. Zen needs a little more from the sidebar than the bookmark tree carries. Each space's profile, emoji icon and theme colors, and favorites kept apart from pinned items. Something like { favorites: [{ url, title, profile }], spaces: [{ id, profile, title, icon, theme, items }] }, where items is the pinned tree of tab and folder entries with split views flattened and Little Arc windows skipped, would cover both of us if that works for you.

Also, what we are at it, we should add Dia support as well! It should be easier than importing from Arc.

Flags: needinfo?(cheff)
Blocks: 2088271

Thanks :cheff!

I've updated my patch to reflect this.
You should be able to extend ArcMigrationUtilsClass and just override the parseArcSpace to the shape you want. The current shape is defined in @typedef {object} ArcSpace. The parseArcSidebar will return { favorites, spaces }.
ArcProfileMigrator should only need to extend _getSidebarResource now as well.

Feel free to request any changes on the patch or reply here if there is anything you'd like to see changed.

Also, what we are at it, we should add Dia support as well! It should be easier than importing from Arc.
Good idea! I've filed bug 2088271 and I'll pick it up shortly

Flags: needinfo?(cheff)
Status: ASSIGNED → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

:niklas Did you want to nominate this for the Fx162 relnotes? If so, set the relnote-firefox flag to "?"

Possible wording:

Firefox can now import data from the Arc browser.

Flags: needinfo?(nbaumgardner)

Release Note Request (optional, but appreciated)
[Why is this notable]:
Arc is shutting down on December 22 and users can now import their data from the Arc browser.
Spaces and favorites are imported as bookmarks in Firefox.

[Suggested wording]:
Firefox can now import data from the Arc browser.

relnote-firefox: --- → ?
Flags: needinfo?(nbaumgardner)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: