186938 - #if 0 code in nsBlender.cpp

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsBlender.cpp has an entire function in an #if 0 block (well only the function
body is in #if 0), and the only caller also in an #if 0 block
The function is Do8Blend, see
http://lxr.mozilla.org/seamonkey/search?string=Do8Blend and follow the links to
nsBlender.cpp

It looks like the if 0 was introduced by pavlov in bug 78690...

When this code is removed, the forward declaration of IL_ColorSpace in
nsBlender.h can also go.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, as a matter of fact, even more code can be removed. I'll attach a patch soon.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 110245 [details] [diff] [review]
patch

r+sr=roc+moz

This code doesn't work anymore anyway. If we need to get it back later we can
recover it from CVS history.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, the patch is checked in

tinderbox shows 2.5 KB Codesize reduction :)

Now... the aBlendQuality argument seems to be completely ignored by the Do*Blend
functions. roc, do you think we should keep it anyway, or should I remove it?


leaving the bug open for that issue.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's not worth playing with nsIBlender at this time. nsIBlender should be
removed, and its functionality moved to nsIRenderingContext or possibly
nsIDrawingSurface.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

ok then, marking fixed.

Comment 7

[Roland Mainz]

Robert O'Callahan wrote:
> It's not worth playing with nsIBlender at this time. nsIBlender should be
> removed, and its functionality moved to nsIRenderingContext or possibly
> nsIDrawingSurface.

What's the bugid for that work ?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No specific bugid, but it's part of bug 186293.