1869397 - Remove LoadLibrary injection protection

Status: RESOLVED FIXED

(Core :: DLL Services, defect)

Description

[Greg Stoll :gstoll]

It's been a year and a half since we had to limit the LoadLibrary injection protection to just Nightly in bug 1762576. We are working towards being able to turn this on, but in the meantime having this code behave differently in Nightly than Beta/Release makes it harder to track down when issues happen. (for an example, see bug 1868531)

Comment 1

[Greg Stoll :gstoll]

(adding cc's for :haik and :gcp in case one of you disagrees :-) )

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 1869397 - remove LoadLibrary injection protection r=mhowell,haik

Comment 3

[Haik Aftandilian [:haik]]

(In reply to Greg Stoll from comment #1)

(adding cc's for :haik and :gcp in case one of you disagrees :-) )

I support doing this. Having the block in Nightly only at this time

• is not helping users because it's limited to Nightly
• makes Nightly not usable as a test case for DLP-related issues
• lets us ask DLP vendors to test Nightly for exercising file dialog remoting

Once bug 1811076 ships and we support the Content Analysis SDK, we should re-attempt LoadLibrary injection protection.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d65114d97d0
remove LoadLibrary injection protection r=mhowell,haik,win-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8d65114d97d0