1869417 - Trim included CPP in `toolkit/mozapps/defaultagent/proxy`

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, enhancement)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Right now, toolkit/mozapps/defaultagent/proxy includes several files from toolkit/mozapps/defaultagent that aren't strictly necessary. This ticket tracks splitting ScheduledTask.cpp so that most of the files aren't needed, which in turn will allow to assume that Gecko is available more broadly in toolkit/mozapps/defaultagent.

Comment 1

[Nick Rishel [:nrishel]]

If we could land Bug 1710143 we could probably remove ScheduledTask.cpp altogether. That patch afaik it ready to go, we just need to build (in a secure environment) and sign the DLL. Edit: scratch that, it seems the commit is only removing (not adding) scheduled tasks.

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1869417 - Trim included CPP in `toolkit/mozapps/defaultagent/proxy`. r?nrishel

By splitting ScheduledTask.cpp, the proxy can include less CPP code.
In turn, this makes it easier to depend on Gecko in toolkit/mozapps/defaultagent.

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

(In reply to Nick Rishel [:nrishel] from comment #1)

If we could land Bug 1710143 we could probably remove ScheduledTask.cpp altogether. That patch afaik it ready to go, we just need to build (in a secure environment) and sign the DLL. Edit: scratch that, it seems the commit is only removing (not adding) scheduled tasks.

Even if it were ready I'd like to take this one first to make Bug 1869423 easier.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a132a0420bee
Trim included CPP in `toolkit/mozapps/defaultagent/proxy`. r=mhughes,nshukla

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a132a0420bee