1869429 - Expand the number of allowed extra keys to an event

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[James Teow [:jteow]]

Hello Glean team,

On Search we're working on Bug 1868476 where we'd like to register a new Glean event with 18 extra_key's, but the current limit is 15. Can the limit be bumped up so that we don't have to split the event into multiple pieces? Possibly to 30 so that other teams could also benefit from the change?

Depending on the sensitive data review, we're hoping to land this in Firefox 122 (if the data review takes longer then possibly 123)

Comment 1

[Chris Bellini (:cbellini)]

Would Fx 122 be a feasible target for this change?

Comment 2

[Jan-Erik Rediger [:janerik]]

We're 4 days out from Fx 122 hitting beta. This requires (minimal) code changes in Glean and a new release and I'm not up for rushing that out before the holidays.
Redirecting to Travis for decision & timeline though.

Comment 3

[Travis Long [:travis_]]

Yeah, we will have folks out for the holidays and I'd rather uplift this after the holidays than try and rush it into the end of nightly now. Chris, would that be acceptable we were able to get this change made and deal with the deployment and uplift to 122 (beta) when everyone is back? Or perhaps just target 123?

Comment 4

[Chris H-C :chutten]

(( Last "early beta" (last time we'd want to uplift anything big or risky) for Fx122 is Jan 5. Final day for any uplifts at all is a week later, Jan 12. ))

Comment 5

[Chris Bellini (:cbellini)]

No concerns if we target Fx 123.

Comment 6

[Travis Long [:travis_]]

The requested 30 keys is good with me. Let's target that for now.

Comment 7

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1869429 - Event extra key limit increased from 15 to 50 total keys (#2705)

Comment 8

[BMO Github Automation]

Attachment: [mozilla/glean_parser] Bug 1869429 - Increase event extra key limit from 15 to 50 (#648)

Comment 9

[Travis Long [:travis_]]

The changes have landed in glean_parser and glean... just need a release and vendor this into desktop before it can be used. I'm closing this bug as FIXED and will start on the deployment of this next.