186943 - the css-loader shouldn't deal with parsers

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The css-loader currently has two callback mechanisms for when a stylesheet is
loaded; it unblocks an nsIParser and it notifies an nsICSSLoaderObserver. This
seems unneccesary.

A better way might be to only have the nsICSSLoaderObserver-notification. The
contentsink can then implement this interface and unblocks the parser. This
seems like a cleaner separation.

I'm planning on doing some work for XSLT that should make this easier, i'll post
the bugnumber for that work here once i have a bug.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I'd rather just fix bug 84582

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

of course that would be even nicer :)

note to self: if we do this one before that we should also change
NS_ERROR_HTMLPARSER_BLOCK to something like NS_ERROR_CSS_LOAD_NOT_FINISHED, or
an outparam

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

i'm using bug 186835 for the XSLT changes that partly paves the way for fixing
this bug.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 84582.