Closed Bug 1869525 Opened 5 months ago Closed 5 months ago

Switching KDE breeze theme from light to dark or viceversa ends up falling back to adwaita until the next settings change.

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

Consider the following situation:

  • We're using the Breeze (light) theme.
  • We switch to dark mode.

When the KDE system theme changes, we get a color scheme change
notification. However by the time we get it, the gtk colorreload module
that KDE uses to communicate its colors to GTK1 hasn't processed the
change yet.

So we end up thinking that Breeze is still light, (and even
special-casing that wouldn't work, because we still get the light
colors). So we fall back to Adwaita-dark, and by the time the file
actually changes we don't get any other notification. I don't think
there's another thing to watch here, unfortunately, but if there is we
should do it. I guess we could patch the color-reload module to send
some sort of signal to the screen / settings objects?

Assignee: nobody → emilio
Status: NEW → ASSIGNED

I tested the patch and it fixes the issue. Thank you very much for the quick fix :)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2df023aa837
Watch KDE's colors.css and trigger theme recomputation when it mutates. r=stransky
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
See Also: → 1874913
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: