Closed Bug 1869532 Opened 2 years ago Closed 2 years ago

Recalculate virtual-list maxRenderCountEstimate on window resize in Firefox View

Categories

(Firefox :: Firefox View, task)

task

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: kcochrane, Assigned: kcochrane)

References

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

Since we use window.innerHeight to determine how many items to render at one time in the virtual-list, we'll need to make sure that value is updated when the window is resized. We should handle this in viewpage.mjs to ensure we're only adding one event listener on the window at one time. We should also use DeferredTask to make sure we're debouncing.

We should land this as a follow-up to bug 1857634, so that we can reference this new updatesPaused property in fxview-tab-list when deciding which virtual-list elements to recalculate values for one window resize.

Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Summary: Recalculate virtual-list maxRenderCountEstimate on window resize → Recalculate virtual-list maxRenderCountEstimate on window resize in Firefox View
Attachment #9368301 - Attachment description: Bug 1869532 - Recalculate virtual-list maxRenderCountEstimate on window resize → WIP: Bug 1869532 - Recalculate virtual-list maxRenderCountEstimate on window resize
Attachment #9368301 - Attachment description: WIP: Bug 1869532 - Recalculate virtual-list maxRenderCountEstimate on window resize → Bug 1869532 - Recalculate virtual-list maxRenderCountEstimate on window resize
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9ee546f4639 Recalculate virtual-list maxRenderCountEstimate on window resize r=fxview-reviewers,sfoster
Regressions: 1870703
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: