1869546 - Make expose_browser_profiler work with gecko_profile as well

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P3)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Currently expose_browser_profiler only works with --extra-profiler-run argument (see). But it should also work with the gecko_profile enabled, which is the main mechanism for profiling in Raptor.

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

thanks for filing this

this is somewhat related to Bug 1853434 (potentially even duplicated by it!)

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Ah, that's right. I think it's directly the duplicate. That's what I was remembering I think but couldn't find the bug. Since that bug has a broader scope, I think it's better to keep them both (that bug also mentions having unexpected iteration counts).

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

Sounds good! Good point about the iter counts. We'll keep both

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1869546 - Make expose_browser_profiler option work with gecko_profile as well r?kshampur!

We have 2 ways to enable the profiler in Raptor:

1. Using --gecko-profile argument locally or in CI, which runs the test only
   with the profiler enabled.
2. Using extra_profiler_run also locally or in the CI, which runs the test
   both normally/without the profiler and then adding an extra run with the
   profiler enabled at the end.

It seems like the expose_browser_profiler flag was only working for the
second case and not when --gecko-profile was passed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be626b381cad
Make expose_browser_profiler option work with gecko_profile as well r=kshampur,perftest-reviewers

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/be626b381cad