1869643 - [meta] Port test coverage from the old implementation of Firefox View to the new implementation

Status: NEW

(Firefox :: Firefox View, task, P2)

Description

[Nikki Sharpley (:nikkis) (she/her)]

The new Firefox View requires the addition of the following tests previously covering old View UI:

• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_recently_closed_tabs_windows.js
  • close_tab_in_other_window - after closing a tab in another window, verify that that recently closed tab can be dismissed from firefox-view in another window
• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js
  • test_time_updates_correctly - test time updates correctly since tab closure
  • test_list_maintains_focus_when_restoring_tab - not sure we have this functionality in the new view?
  • test_switch_before_closing - ensure if a tab navigates elsewhere before closure that the correct url displays in view
  • test_alt_click_no_launch - is it still expected behaviour to not launch the recently closed tab on alt click?
• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_setup_state.js - test device connection and sync
  • test_mobile_connected
  • test_tablet_connected
  • test_tab_sync_enabled
• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_setup_synced_tabs_loading.js - test loading and no sync states
  • test_tab_sync_loading
  • test_tab_no_sync
  • test_recent_tabs_loading
• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_sync_admin_disabled.js
  • test_sync_admin_disabled - not sure whether this functionality exists in the new implementation?
• https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/browser/components/firefoxview/tests/browser/browser_setup_errors.js - some error state tests are missing from the new implementation
  • test_sync_error_signed_out
  • test_sync_disconnected_error
  • test_password_change_disconnect_error
  • test_multiple_errors
• https://searchfox.org/mozilla-central/rev/c3263d48f391c2c6c984b874986341baf667bf12/browser/components/firefoxview/tests/browser/browser_setup_primary_password.js - we should look into how the new implementation of view handles this
• https://searchfox.org/mozilla-central/rev/c3263d48f391c2c6c984b874986341baf667bf12/browser/components/firefoxview/tests/browser/browser_sync_admin_disabled.js - we should look into how the new implementation of view handles this

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

(accidental comment)