1869661 - Crash in [@ mozilla::gfx::DrawTargetRecording::DrawTargetRecording]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/9aefb33c-4516-4a2a-aa78-e9b450231212

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  mozilla::gfx::DrawTargetRecording::DrawTargetRecording  gfx/2d/DrawTargetRecording.cpp:198
1  xul.dll  mozilla::MakeAndAddRef  mfbt/RefPtr.h:629
1  xul.dll  mozilla::layers::CanvasChild::CreateDrawTarget  gfx/layers/ipc/CanvasChild.cpp:282
2  xul.dll  mozilla::layers::RecordedTextureData::Lock  gfx/layers/client/TextureRecorded.cpp:51
3  xul.dll  mozilla::layers::TextureClient::Lock  gfx/layers/client/TextureClient.cpp:624
4  xul.dll  mozilla::layers::PersistentBufferProviderShared::BorrowDrawTarget  gfx/layers/PersistentBufferProvider.cpp:445
5  xul.dll  mozilla::dom::CanvasRenderingContext2D::TrySharedTarget  dom/canvas/CanvasRenderingContext2D.cpp:1697
6  xul.dll  mozilla::dom::CanvasRenderingContext2D::EnsureTarget  dom/canvas/CanvasRenderingContext2D.cpp:1519
7  xul.dll  mozilla::dom::CanvasRenderingContext2D::FillRect  dom/canvas/CanvasRenderingContext2D.cpp:3033
8  xul.dll  mozilla::dom::CanvasRenderingContext2D_Binding::fillRect  dom/bindings/CanvasRenderingContext2DBinding.cpp:6935

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1869661 - Add more null checks for CanvasChild::mRecorder.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1863914

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f82f965831a
Add more null checks for CanvasChild::mRecorder. r=gfx-reviewers,lsalzman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3f82f965831a