1869667 - [wpt-sync] Sync PR 43637 - Implement the ic-height metric of font-size-adjust

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43637 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43637
Details from upstream follow.

ChangSeok Oh <[e-mail]> wrote:

Implement the ic-height metric of font-size-adjust

This CL adds the ic-height metric support to font-size-adjust [1]. The
ic-height metric lets developers adjust font size relative to the height
of the CJK water glyph. A note-worthy is the fallback case where the
used font does not provide vertical font info. Such vertical font info
is often missing, but the current specification does not describe the
fallback behavior. As a temporary measure, we use the advance width of
the CJK water glyph instead until the standard fallback behavior is
established [2] if we cannot get its advance height from the font. That
would be a sensible approximation since the CJK water glyph has the same
width and height in most fonts.

[1] https://www.w3.org/TR/css-fonts-5/#valdef-font-size-adjust-ic-height
[2] https://github.com/w3c/csswg-drafts/issues/8792

Test:
external/wpt/css/css-fonts/animations/font-size-adjust-composition.html
external/wpt/css/css-fonts/font-size-adjust-ic-height.html (new)
external/wpt/css/css-fonts/parsing/font-size-adjust-computed.html
external/wpt/css/css-fonts/parsing/font-size-adjust-valid.html

Bug: 1219875
Change-Id: Ie90a6241cb7e8a55fcaf65df5a4edc1058028ebe
Reviewed-on: https://chromium-review.googlesource.com/5118658
WPT-Export-Revision: 950103e0e10449d10252c99e0f098820170f4d09

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=36c9559a8860ac4fe71977b74d05030cb2d8d202

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-fonts/font-size-adjust-ic-height.tentative.html [wpt.fyi]: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ee03392d19
[wpt PR 43637] - Implement the ic-height metric of font-size-adjust, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3a5cfc1b8901
[wpt PR 43637] - Update wpt metadata, a=testonly

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/b6ee03392d19
https://hg.mozilla.org/mozilla-central/rev/3a5cfc1b8901