1869771 - :has() is not consistently applied in www.matuzo.at/blog/2022/100daysof-day50

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot

As reported in bug 418039 comment 82. See screenshot, border should be dotted.

David, can you look? This one is rather odd. Maybe some style sharing issue?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Somewhat reduced test-case.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case.

Comment 3

[David Shin[:dshin]]

Attachment: Minimized Test Case

1. First .sib's .cousin goes into the cache
2. Second .sib's first .cousin does style computation, then cascade, where we realize we can share because we match the 1)'s rules exactly while parents also share the style.
3. The reused style loses information on being considered for :has() matching
4. Second .sib's second .cousin now shares style with the first

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1869771: Prevent rule-based style sharing on elements that considered a relative selector. r=emilio

Comment 5

[Michal Čaplygin [:myf]]

Attachment: Reduced demonstrative test-case

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cac055166c6d
Prevent rule-based style sharing on elements that considered a relative selector. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43714 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cac055166c6d

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot