1869842 - Expand `MockRegistry` to support more: registry types, subkeys/children, etc

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task, P3)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

This ticket tracks making MockRegistry support more of the Windows registry API, including registry types and subkeys/children. And, while we're in the neighbourhood, testing it against the same battery as https://searchfox.org/mozilla-central/source/xpcom/tests/unit/test_windows_registry.js.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

There's no dependency relationship, but it's good to be aware of Bug 1852781 when working in the area -- especially when testing.

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1869842 - Extend `MockRegistry` to support types and subkeys/children r?nrishel

This implements registry types by storing a pair of [value, type].

This implements subkeys/children by nesting "keys" with children and
values maps.

The biggest limitation added is to have the store be a static on
the MockRegistry class rather than on each instance. This allows to
refer to MockWindowsRegKey more easily, rather than having that
class be scoped to the specific MockRegistry instance.

Finally, this tests the MockRegistry interface in the same way we
test the native Windows registry interface.

Comment 3

[Nipun Shukla]

Attachment: WIP: Bug 1869842 - Extend MockRegistry to support types and subkeys r?nrishel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c19bbbde9f0
Extend `MockRegistry` to support types and subkeys/children r=nrishel

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7c19bbbde9f0