1869884 - Downloads dont clear properly when cleared alone

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P3)

Description

[Harshit Sohaney]

Currently, downloads initiated through the new clear history dialog interface don't disappear when you try to delete them individually. This is because download clearing is tied to clearing browsing history. We're working on making it possible to clear downloads independently.

Comment 1

[Harshit Sohaney]

We will be remerging downloads into the browsing history checkbox due to engineering work requirements for this feature to ship with time restrictions.

Comment 2

[Harshit Sohaney]

Attachment: Bug 1869884 - Remerging downloads into history. r?pbz

Depends on D197952

Comment 3

[Harshit Sohaney]

Attachment: Bug 1869884 - (part 2) update tests to reflect new pref and removal of downloads. r?pbz

Depends on D198393

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7969278ce39f
Remerging downloads into history. r=pbz,fluent-reviewers,bolsson

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_sanitizeDialog_v2.js

• backout: https://hg.mozilla.org/integration/autoland/rev/c0654cf190bd57f655e32158e9d60bc70d26e0f0
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=aM-SzGz3QW2RkL_Q6y-EBw.0&revision=7969278ce39fb302c3bee8f0db090958192ce28e
• failure log: https://treeherder.mozilla.org/logviewer?job_id=443846204&repo=autoland&lineNumber=8363

[task 2024-01-18T22:30:58.505Z] 22:30:58     INFO - TEST-PASS | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | Sanity check: download fakefile-65-minutes-ago should exist after creating it - 
[task 2024-01-18T22:30:58.505Z] 22:30:58     INFO - Buffered messages finished
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js | Uncaught exception in test bound test_clear_on_shutdown - [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://mochitests/content/browser/browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js :: boolPrefIs :: line 82"  data: no]
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - Stack trace:
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - boolPrefIs@chrome://mochitests/content/browser/browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js:82:21
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - test_clear_on_shutdown@chrome://mochitests/content/browser/browser/base/content/test/sanitize/browser_sanitizeDialog_v2.js:973:13
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1138:26
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1127:14
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-01-18T22:30:58.507Z] 22:30:58     INFO - Leaving test bound test_clear_on_shutdown
[task 2024-01-18T22:30:58.508Z] 22:30:58     INFO - Entering test bound test_defaults_prefs

Comment 6

[Harshit Sohaney]

Looks like there was a rebase error that I overlooked, sorry about that! Fixing it up right now

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/811ac0a6fd8e
Remerging downloads into history. r=pbz,fluent-reviewers,bolsson

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/811ac0a6fd8e